Closed
Bug 1345079
Opened 8 years ago
Closed 8 years ago
Allowing screensharing with no screen selected will temporarily block the camera
Categories
(Firefox :: Site Identity, defect, P1)
Firefox
Site Identity
Tracking
()
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | + | verified |
firefox54 | --- | verified |
firefox55 | --- | verified |
People
(Reporter: johannh, Assigned: nhnt11, Mentored)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxprivacy] )
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
johannh
:
review+
gchang
:
approval-mozilla-aurora+
gchang
:
approval-mozilla-beta+
|
Details |
STR:
- Go to https://people-mozilla.org/~fqueze2/webrtc/
- Click on "Screen"
- Click "Allow" without selecting a screen to share
- Notice that the camera is temporarily blocked
This is because this line http://searchfox.org/mozilla-central/source/browser/modules/webrtcUI.jsm#752 assumes we always share the camera and doesn't account for sharingScreen.
It should probably simply return; when sharingScreen is true since that means the user has not selected a screen. I don't think it's fair to temp block the website here as the user could have made that choice accidentally.
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]: regression from bug 1206232 which landed for 53.
status-firefox53:
--- → affected
status-firefox54:
--- → affected
tracking-firefox53:
--- → ?
Keywords: regressionwindow-wanted
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nhnt11
Flags: needinfo?(nhnt11)
Updated•8 years ago
|
Iteration: --- → 55.1 - Mar 20
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.
https://reviewboard.mozilla.org/r/119786/#review121668
Looks great, thanks for spotting the redundant else branch there.
Attachment #8846782 -
Flags: review?(jhofmann) → review+
Comment 6•8 years ago
|
||
Please land and request uplift to 54 and 53. Thanks!
Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/45028a73f2c9
Allowing screensharing with no screen selected should not block the camera. r=johannh
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.
Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1206232
[User impact if declined]: Confusing behavior, see bug title.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, but STR are in comment 0.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It removes a block of code that sets "block" permission within the callback for the "Allow" button. That code shouldn't be there, and removing it can't cause any harm.
[String changes made/needed]: none
Flags: needinfo?(nhnt11)
Attachment #8846782 -
Flags: approval-mozilla-beta?
Attachment #8846782 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 10•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 11•8 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-03-07) (64-bit) on Windows 7 , 64 Bit!
This bug's fix is verified with latest Nightly!
Build ID : 20170317030204
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
[bugday-20170315]
Comment 12•8 years ago
|
||
Build ID: 20170317030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Comment 13•8 years ago
|
||
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.
Fix a regression issue related to permission and was verified. Aurora54+ & Beta53+.
Attachment #8846782 -
Flags: approval-mozilla-beta?
Attachment #8846782 -
Flags: approval-mozilla-beta+
Attachment #8846782 -
Flags: approval-mozilla-aurora?
Attachment #8846782 -
Flags: approval-mozilla-aurora+
Comment 14•8 years ago
|
||
bugherder uplift |
Comment 15•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
QA Whiteboard: [good first verify]
Comment 16•8 years ago
|
||
Build ID: 20170321004003
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Verified as fixed on Firefox Aurora 54.0a2 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Updated•8 years ago
|
Comment 17•8 years ago
|
||
Verified as fixed on Firefox Beta 53.0b5 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Updated•6 years ago
|
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•