Closed
Bug 1345324
Opened 8 years ago
Closed 8 years ago
Label runnables for CDMProxy sub-classes
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
(Whiteboard: [QDL][TDC-MVP][MEDIA])
Attachments
(1 file)
They are MediaDrmCDMProxy and GMPCDMProxy.
|
Assignee | |
Updated•8 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8844765 [details]
Bug 1345324 - Label runnables for CDMProxy sub-classes.
https://reviewboard.mozilla.org/r/118092/#review119940
Thanks for writing these patches.
You could pass the event target to the CDMProxy constructor, so that each implementation doesn't need to remember to set CDMProxy::mMainThread to aMainThread in their Init method. That way you reduce the duplicated code that sets CDMProxy::mThread.
Attachment #8844765 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8844765 [details]
Bug 1345324 - Label runnables for CDMProxy sub-classes.
https://reviewboard.mozilla.org/r/118092/#review119940
Yes, I can do that in a new bug for I want to keep changes in control flow as minimized as possible in this bug.
http://searchfox.org/mozilla-central/rev/d4adaabd6d2f88be0d0b151e022c06f6554909da/dom/media/eme/MediaKeys.cpp#376
To pass |top->GetExtantDoc()->EventTargetFor()| to the constructor of CDMProxy, you have to deal with exceptions like null |window| or null |top| first.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74bd66f2490e
Label runnables for CDMProxy sub-classes. r=cpearce
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•8 years ago
|
Whiteboard: [QDL][TDC-MVP][MEDIA]
You need to log in
before you can comment on or make changes to this bug.
Description
•