Closed Bug 1345597 Opened 8 years ago Closed 7 years ago

Signing into an FxA account which requires email verification will not auto-start sync on completion

Categories

(Firefox for iOS :: Firefox Accounts, enhancement, P2)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.22
Tracking Status
fxios 8.0+ ---

People

(Reporter: sleroux, Assigned: jhugman)

References

Details

(Whiteboard: [MobileCore])

Attachments

(1 file, 1 obsolete file)

To resolve the timed auto-navigation that was occurring on iOS after the verification logic went live in December on the FxA server (which was causing the FxA credentials to be lost after inputting), we recently deployed some logic to remove this delay and have the FxA server send us back the token right way [1]. We also added some code to auto dismiss if we were already verified. The existing iOS client logic is to take the token that is sent from the server, create a local FirefoxAccount object, and begin syncing if it is able to [2]. Since the server is now sending the token back immediately instead of after the account has been verified, the sync doesn't auto-start because account still needs to be verified. Once that account is verified there is _no way for the server to tell the client_. I believe the assumption was that when a user forces a sync, this will sort itself out but is sub-optimal for first logins as the sync won't happen until next launch. This in turn is causing the two reported bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1344664 https://bugzilla.mozilla.org/show_bug.cgi?id=1344717 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=13354 [2] https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Settings/SettingsTableViewController.swift#L368 & https://github.com/mozilla-mobile/firefox-ios/blob/master/Providers/Profile.swift#L556
> Once that account is verified there is _no way for the server to tell the client_. On desktop we solve this with a combination of: * Registering a device record with push callback (which can be done before verification completes) and listening for a push message. * Polling the FxA server to ask whether the sessionToken has been verified. A bit of light polling might be the easiest option until push is up and running.
> Registering a device record with push callback (which can be done before verification completes) and listening for a push message. I think that's the end goal for iOS once we land some of the push work for send tab. > Polling the FxA server to ask whether the sessionToken has been verified. This would be a good option in the interim. We might be able to find a clever way of timing the poll to closely coincide with when the user expects the sync to occur.
Comment on attachment 8845650 [details] Bug 1345597 - Add a check for the inspector toolbox when checking if the grid inspector or box model is visible. Wrong Bug Number :X
Attachment #8845650 - Attachment is obsolete: true
Attachment #8845650 - Flags: review?(jdescottes)
Well need to be careful to make sure we poll at the 3 points we sign in from: Home panel, intro tour, and settings
I don't think this is urgent enough to deal with for 7.x. Moving back to triage to talk about that.
Priority: P1 → P2
Whiteboard: [MobileCore]
Assignee: nobody → jhugman
Iteration: --- → 1.20
Status: NEW → ASSIGNED
Iteration: 1.20 → 1.21
Iteration: 1.21 → ---
Attachment #8868323 - Flags: review?(fpatel) → review+
Iteration: --- → 1.22
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This shipped for 8.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: