Closed
Bug 1345639
Opened 8 years ago
Closed 8 years ago
Rewrite the ASHorizontalScrollCell as a UICollectionViewCell
Categories
(Firefox for iOS :: Home screen, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.17
People
(Reporter: farhan, Assigned: farhan)
References
Details
(Whiteboard: [mobileAS])
Attachments
(1 file)
ASHorizontalScrollCell is the cell that shows the Top Sites in Activity Stream. Make sure that it is a UICollectionViewCell now as it appears in a UICollectionView instead of a UITableView.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → fpatel
Iteration: --- → 1.17
Priority: P2 → P1
|
|
Assignee | |
Comment 1•8 years ago
|
||
There are 2 seperate Bugs in here. I snuck the redesign of Topsites in here as well. It is its own commit though but in the same PR.
Attachment #8846067 -
Flags: review?(bmunar)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8846067 [details]
Pull Request
couple of questions but looks good - probably want someone to review all of this new AS code a second time when it's all said and done!
Attachment #8846067 -
Flags: review?(bmunar) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
I've merged this into the open PR related to iPad support. There are some follow up bugs I dont want to address until the rest of the panel is done.
https://github.com/mozilla-mobile/firefox-ios/pull/2510
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•