Gabriele Svelto [:gsvelto] Assignee
	Description • 7 years ago

+++ This bug was initially created as a clone of Bug #1280477 +++

When I've implemented bug 1280477 I pref'd off gathering stack traces from main process crashes in beta/release. However in bug 1293656 I didn't add a similar limitation so we're currently in a situation where our beta release is gathering stacks for content crashes but not for main process crashes. Since this feature has proven itself stable let's turn it on across all channels and uplift to aurora/beta so that we're consistent with this feature.

	Benjamin Smedberg
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8845405 [details]
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes

https://reviewboard.mozilla.org/r/118600/#review121142

	Gabriele Svelto [:gsvelto] Assignee
	Comment 3 • 7 years ago

Thanks for the review Benjamin, the try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=771dfd513b3b6561e30a5c10d99c9fd48510c4f6

	Pulsebot
	Comment 4 • 7 years ago

Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/967422f569ae
Enable client-side stack-walking on beta and release for main process crashes r=bsmedberg

	Carsten Book [:Tomcat]
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/967422f569ae

	Gabriele Svelto [:gsvelto] Assignee
	Comment 6 • 7 years ago

Comment on attachment 8845405 [details]
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes

Approval Request Comment
[Feature/Bug causing the regression]: This enables the functionality of bug 1280477 in beta/release
[User impact if declined]: Invisible to the user, but we don't get stacks in crash-pings from main process crashes in beta/release
[Is this code covered by automated tests?]: It's partially covered by tests and it's gone through extensive manual testing in QA
[Has the fix been verified in Nightly?]: Yes, it's been in nightly for months
[Needs manual test from QE? If yes, steps to reproduce]: It's already been manually tested
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No risk
[Why is the change risky/not risky?]: In aurora it doesn't change anything since the functionality of bug 1280477 is already enabled there, it will have an impact only when it gets into beta
[String changes made/needed]: None

	Gerry Chang [:gchang]
	Comment 7 • 7 years ago

Comment on attachment 8845405 [details]
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes

Help to get stacks in crash-pings from main process crashes. Aurora54+.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 8 • 7 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/b727bf4a09acc7ebbc5265429665fb846e5c9058

	Gabriele Svelto [:gsvelto] Assignee
	Comment 9 • 7 years ago

Comment on attachment 8845405 [details]
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes

Approval Request Comment
[Feature/Bug causing the regression]: This enables the functionality of bug 1280477 in beta/release
[User impact if declined]: Invisible to the user, but we don't get stacks in crash-pings from main process crashes in beta/release
[Is this code covered by automated tests?]: It's partially covered by tests and it's gone through extensive manual testing in QA
[Has the fix been verified in Nightly?]: Yes, it's been in nightly for months
[Needs manual test from QE? If yes, steps to reproduce]: It's already been manually tested
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: This carries a very small risk of causing issues within the crashreporter since it will now invoke an external tool to gather stack traces.
[Why is the change risky/not risky?]: This has been enabled on nightly/aurora for months and it didn't cause issues, the risk is small because almost all the added code resides in an external tool that is run from the crashreporter. The idea is that even if we hit a significant bug in the tool, the worse that can happen is that we won't gather stack traces, but we won't cause issues to the crashreporter itself which should continue running unaffected.
[String changes made/needed]: None

	Gerry Chang [:gchang]
	Comment 10 • 7 years ago

Comment on attachment 8845405 [details]
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes

Enable getting stacks in crash-pings from main process crashes.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 11 • 7 years ago

Thanks Gerry, I'm uplifting this right away.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 12 • 7 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/c385ff88725dd45405c7cd52feb4ed6604946a1c