Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 7 years ago

Ideally, we should fix bug 1319340, but there are still some implementation in automated tests which implements nsIEditor and something.

For now, for reducing the runtime query cost, let's create AsTextEditor() and AsHTMLEditor() to EditorBase.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8845734 [details]
Bug 1345763 part.1 Implement AsTextEditor() in EditorBase and its subclasses and replace casts with it

https://reviewboard.mozilla.org/r/118880/#review120832

::: editor/libeditor/HTMLEditor.cpp:507
(Diff revision 1)
>  HTMLEditor::InitRules()
>  {
>    if (!mRules) {
>      // instantiate the rules for the html editor
>      mRules = new HTMLEditRules();
>    }
> -  return mRules->Init(static_cast<TextEditor*>(this));
> +  return mRules->Init(AsTextEditor());

Although, this is NOT a risky cast because of referring its superclass. So, if you don't like this, I'll revert here.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45ec17cb9569

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 5 • 7 years ago

Oops, the cast must be redundant. I'll repost the patch after checking in tryserver.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 8 • 7 years ago

Okay, the cast isn't necessary for any compilers.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 9 • 7 years ago
mozreview-review

Comment on attachment 8845734 [details]
Bug 1345763 part.1 Implement AsTextEditor() in EditorBase and its subclasses and replace casts with it

https://reviewboard.mozilla.org/r/118880/#review121006

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 10 • 7 years ago
mozreview-review

Comment on attachment 8845735 [details]
Bug 1345763 part.2 Implement AsHTMLEditor() in EditorBase and its subclasses and replace casts with it

https://reviewboard.mozilla.org/r/118882/#review121008

::: editor/libeditor/HTMLEditorEventListener.cpp:222
(Diff revision 2)
>  }
>  
>  nsresult
>  HTMLEditorEventListener::MouseClick(nsIDOMMouseEvent* aMouseEvent)
>  {
> +  if (NS_WARN_IF(DetachedFromEditor())) {

Unrelated change, but fine.

	Pulsebot
	Comment 11 • 7 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/a0a3c9bacb1e
part.1 Implement AsTextEditor() in EditorBase and its subclasses and replace casts with it r=smaug
https://hg.mozilla.org/integration/autoland/rev/743d5c04dc07
part.2 Implement AsHTMLEditor() in EditorBase and its subclasses and replace casts with it r=smaug

	Carsten Book [:Tomcat]
	Comment 12 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a0a3c9bacb1e
https://hg.mozilla.org/mozilla-central/rev/743d5c04dc07