Closed
Bug 1345863
Opened 8 years ago
Closed 7 years ago
use job_try_name for toolchain, android-stuff kinds
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla55
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(1 file, 1 obsolete file)
Follow-on from bug 1337903, where I created job_try_name and used it for the source-test kind.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8863511 -
Flags: review?(ahalberstadt)
|
|
Assignee | |
Comment 2•8 years ago
|
||
@ahal, ping? should I reassign to someone else?
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8863511 -
Flags: review?(ahalberstadt) → review?(gps)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8863511 [details]
Bug 1345863: set the job_try_name for all tasks governed by -j
https://reviewboard.mozilla.org/r/135284/#review141312
I can't grant r+ because I can't verify how this works! The diff references a "try_job" transform. But when I pull this changeset locally, there is no such transform defined in the repo! It feels like this changeset is part of a larger series of work. But without the parent changesets available in the review repo, I have no clue how this change fits into it.
Also, please write a commit message with more than a summary line.
Attachment #8863511 -
Flags: review?(gps) → review-
|
|
Assignee | |
Comment 4•8 years ago
|
||
Indeed, I had forgotten `hg addremove`!
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8863511 -
Attachment is obsolete: true
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866841 [details]
Bug 1345863: set the job_try_name for all tasks governed by -j;
https://reviewboard.mozilla.org/r/138430/#review142276
Ah, this makes much more sense with the missing file present!
Attachment #8866841 -
Flags: review?(gps) → review+
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e89ecb5ae697
set the job_try_name for all tasks governed by -j; r=gps
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•