Bug 1320732 made it so that web authors can override the borders of checkbox and radio inputs if -moz-appearance is set to none. However, since Fennec has checkboxes and radio inputs set at -moz-appearance: none by default, that meant that it was possible to do something like: * { border-width: 0px; } And suddenly all of your checkboxes and radios don't have borders anymore. In bug 1340661, I'm working on a solution that's going to add pseudo-native checkbox and radio controls to Fennec via its own nsNativeThemeAndroid implementation of nsITheme, but I don't think that's safe to uplift. I suggest we back out bug 1320732 from all channels, and block it on bug 1340661, which should allow us to fix it properly. [Tracking Requested - why for this release]: Users might visit some web properties with hard to see (or invisible) checkboxes or radios on Fennec.

Comment on attachment 8845539 [details] Bug 1345956 - Back out bug 1320732 (changeset 36be06539887) for sometimes making checkboxes / radio buttons hard to see. https://reviewboard.mozilla.org/r/118666/#review121034

Thanks - ni?ing myself for uplift requests.

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f9f8d164fce Back out bug 1320732 (changeset 36be06539887) for sometimes making checkboxes / radio buttons hard to see. r=snorp

Merged backout https://hg.mozilla.org/mozilla-central/rev/7f9f8d164fce Can you resolve the bug and set the proper status flags if this fixes this bug?

Sure, done. Thanks for the reminder!

Comment on attachment 8845539 [details] Bug 1345956 - Back out bug 1320732 (changeset 36be06539887) for sometimes making checkboxes / radio buttons hard to see. Approval Request Comment [Feature/Bug causing the regression]: Bug 1320732 [User impact if declined]: It will be possible for Fennec users to visit websites where checkboxes and radio form controls will be very hard to see because their borders are invisible. [Is this code covered by automated tests?]: Not exactly. We don't test for the visibility of checkboxes / radio buttons in the particular case that this bug was filed for - though we certainly do test the visibility of those form controls in other configurations. [Has the fix been verified in Nightly?]: Yes, I just verified it. [Needs manual test from QE? If yes, steps to reproduce]: I don't thinks so. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: This is a backout of a small style change. We're going back to a style rule that we've been shipping for years. [String changes made/needed]: None.

Comment on attachment 8845539 [details] Bug 1345956 - Back out bug 1320732 (changeset 36be06539887) for sometimes making checkboxes / radio buttons hard to see. Backout because of user impact, let's land this for beta 2 today.

Track 54+ as this is a regressed UI issue.