Closed Bug 1345972 Opened 8 years ago Closed 7 years ago

Android emulator tests download tooltool.py from github

Categories

(Firefox for Android Graveyard :: Testing, defect, P3)

defect

Tracking

(firefox59 fixed, firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

tooltool.py is not in the initial docker image for Android test jobs. It is in-tree at $topsrcdir/taskcluster/docker/recipes/tooltool.py, but android_emulator_unittest.py tries to set up the emulator (tooltool downloads of emulator and avd) before fetching the source: Android test jobs start faster by fetching and unarchiving source, etc while the emulator is starting. I wonder if tooltool.py could be treated more like scripts/xvfb.sh or bin/run-mozharness.
Priority: -- → P1
Flags: needinfo?(dustin)
Priority: P1 → P3
It could, yes :) Make it so!
Flags: needinfo?(dustin)
Blocks: 1425322
https://treeherder.mozilla.org/#/jobs?repo=try&revision=71f00f978963d52717f098a5efb7c05a33d9b657 https://treeherder.mozilla.org/logviewer.html#?job_id=158266721&repo=try&lineNumber=657 [task 2018-01-24T19:02:11.661Z] 19:02:11 INFO - Calling ['python', '/builds/worker/scripts/tooltool.py', '--url', 'http://relengapi/tooltool/', 'fetch', '-m', '/builds/worker/workspace/build/.android/releng.manifest', '-o', '-c', '/builds/worker/tooltool_cache'] with output_timeout 600 [task 2018-01-24T19:02:11.705Z] 19:02:11 INFO - INFO - File AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz not present in local cache folder /builds/worker/tooltool_cache [task 2018-01-24T19:02:11.706Z] 19:02:11 INFO - INFO - Attempting to fetch from 'http://relengapi/tooltool/'... [task 2018-01-24T19:02:14.919Z] 19:02:14 INFO - INFO - File AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz fetched from http://relengapi/tooltool/ as /builds/worker/workspace/build/.android/tmpcIsZWt [task 2018-01-24T19:02:16.123Z] 19:02:16 INFO - INFO - File integrity verified, renaming tmpcIsZWt to AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz [task 2018-01-24T19:02:16.123Z] 19:02:16 INFO - INFO - Updating local cache /builds/worker/tooltool_cache... [task 2018-01-24T19:02:16.252Z] 19:02:16 INFO - INFO - Local cache /builds/worker/tooltool_cache updated with AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz [task 2018-01-24T19:02:16.253Z] 19:02:16 INFO - INFO - untarring "AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz" [task 2018-01-24T19:02:21.230Z] 19:02:21 INFO - Return code: 0
Attachment #8945189 - Flags: review?(jmaher)
Comment on attachment 8945189 [details] [diff] [review] add tooltool.py to docker image and use it from android tests Review of attachment 8945189 [details] [diff] [review]: ----------------------------------------------------------------- good idea!
Attachment #8945189 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/544e1a63dd16 Do not download tooltool.py during Android test tasks; r=jmaher
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Blocks: 1296148
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: