Closed
Bug 1346145
Opened 8 years ago
Closed 8 years ago
Label nsIDocument::SelectorCache
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The SelectorCache::NotifyExpired() will be run by the nsExpirationTracker::TimerCallback which is unlabeled according to the analysis in bug 1333984 comment 10:
> (u'nsIDocument::SelectorCache', 284)
I like to take this bug as an example of how to label nsExpirationTracker by the change will be done in bug 1345464.
The bonus of this bug is that the anonymous Runnable of SelectorCacheKeyDeleter dispatched in SelectorCache::NotifyExpired() will also be labeled to reduce the number of anonymous runnables in the telemetry report in bug 1333984! :)
|
Assignee | |
Comment 1•8 years ago
|
||
SelectorCache::NotifyExpired() will be invoked by nsExpirationTracker::TimerCallback() from an unlabel runnable(nsITimer).
We adopt the change in nsExpirationTracker from bug 1345464 to provide a DocGroup EventTarget for the invocation of this callback.
Hi Ehsan,
May I have your review for this change?
Thanks!
Attachment #8846524 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Note: The SelectorCacheKeyDeleter runnable will be removed in bug 1332491.
|
||
Updated•8 years ago
|
Attachment #8846524 -
Flags: review?(ehsan) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/975e8f260347
Label nsIDocument::SelectorCache. r=ehsan
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•