You are mixing the changes, why that?

(In reply to Sylvestre Ledru [:sylvestre] from comment #2) > You are mixing the changes, why that? I don't know what you're saying here: unless I'm totally mistaken by the way "EARLY_BETA_OR_EARLIER" [1] works this should be exactly as it is supposed to be. [1] from the outcome of our chat, EARLY_BETA_OR_EARLIER should ALSO include DEV_EDITION and NIGHTLY, right?

Comment on attachment 8845864 [details] Bug 1346172 - Fix Geolocation prefs. https://reviewboard.mozilla.org/r/119008/#review121124 ::: browser/app/profile/firefox.js:1257 (Diff revision 1) > // > - > -// Geolocation preferences for the RELEASE channel. > +// Geolocation preferences for Nightly/Aurora/Early Beta. > +// > // Some of these prefs are specified even though they are redundant; they are > -// here for clarity and end-user experiments. > -#ifdef RELEASE > +// here for clarity. > +#ifdef EARLY_BETA_OR_EARLIER Seems like your diff would be simpler and easier to review if you just replaced `#ifdef RELEASE` with the inverted logic `#ifndef EARLY_BETA_OR_EARLIER`.

Exactly what Chris said :)

(In reply to Sylvestre Ledru [:sylvestre] from comment #5) > Exactly what Chris said :) Oh, I see. The explanation is trivial: consistency with the surrounding context. There's no other negative EARLY_BETA_OR_EARLIER check anywhere in the pref file. Anyhow, it's been updated.

Comment on attachment 8845864 [details] Bug 1346172 - Fix Geolocation prefs. https://reviewboard.mozilla.org/r/119008/#review122516 Thanks, much better!

(In reply to Sylvestre Ledru [:sylvestre] from comment #8) > Thanks, much better! Thank you!:)

Pushed by mdesimone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0198076d288f Fix Geolocation prefs. r=sylvestre