Closed Bug 1346378 Opened 8 years ago Closed 8 years ago

Grid Inspector toggle does not appear for display: [inline-]grid !important

Categories

(DevTools :: Inspector: Rules, defect, P3)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox55 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

1346378.patch
(deleted), patch
gl
: review+
Details | Diff | Splinter Review
No description provided.
Flags: qe-verify+
Comment on attachment 8846096 [details] Bug 1346378 - Grid inspector toggle should appear for display: [inline-]grid declarations. https://reviewboard.mozilla.org/r/119176/#review121140 Looks good. Should be easy to add a test here, can you file a follow up or attach one here?
Attachment #8846096 - Flags: review?(jdescottes) → review+
Blocks: 1347964
No longer blocks: 1347964
Attached patch 1346378.patch (deleted) — — Splinter Review
Attachment #8846096 - Attachment is obsolete: true
Attachment #8848493 - Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a13dc6642789 Grid inspector toggle should appear for display: [inline-]grid !important declarations. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/a13dc6642789
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I reproduced this issue using Fx55.0a1, build ID: 20170310090116, on Windows 10 x64. I can confirm this issue is fixed, I verified using Fx55.0b3, on Windows 10 x64, macOS X 10.12.5 and Ubuntu 14.04 LTS. Cheers!
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: