Closed Bug 1346390 Opened 8 years ago Closed 8 years ago

[findbugs] Boxing/unboxing to parse a primitive org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.getDeviceRegistrationTimestamp()

Categories

(Firefox for Android Graveyard :: Firefox Accounts, defect)

Product:
Firefox for Android Graveyard
Component:
Firefox Accounts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed, firefox54 fixed, firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(2 files)

Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency
(deleted), text/x-review-board-request
nalexander
: review+
Details
unboxing-fix-beta.patch
(deleted), patch
lizzard
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review
A follow-up for Bug 1329793.
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Blocks: 1329793
Comment on attachment 8846113 [details] Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency https://reviewboard.mozilla.org/r/119196/#review121168
Attachment #8846113 - Flags: review?(nalexander) → review+
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/378722287469 Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander
https://hg.mozilla.org/mozilla-central/rev/378722287469
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Attached patch unboxing-fix-beta.patch (deleted) — — Splinter Review
Follow up for Bug 1329793. [Feature/Bug causing the regression]: Bug 1329793 [User impact if declined]: findbugs complains in automation [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: no [Why is the change risky/not risky?]: One line fix, changing which static method of Long is used for parsing. [String changes made/needed]: no
Attachment #8850090 - Flags: approval-mozilla-beta?
Attachment #8850090 - Flags: approval-mozilla-aurora?
Comment on attachment 8850090 [details] [diff] [review] unboxing-fix-beta.patch Fix for test failure issues for FxA/sync. Let's uplift this so we can bring up some other fixes for send to tabs.
Attachment #8850090 - Flags: approval-mozilla-beta?
Attachment #8850090 - Flags: approval-mozilla-beta+
Attachment #8850090 - Flags: approval-mozilla-aurora?
Attachment #8850090 - Flags: approval-mozilla-aurora+
Setting qe-verify- based on comment 6.
Flags: qe-verify-
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: