Closed
Bug 1346443
Opened 8 years ago
Closed 8 years ago
MozReview lands commit message as file to the repo
Categories
(Conduit :: Transplant, enhancement)
Conduit
Transplant
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1346321
People
(Reporter: xidorn, Unassigned)
Details
Please see bug 1345498 comment 22. The commit https://hg.mozilla.org/integration/autoland/rev/b17b5fdb4ae7 landed in that bug contains a file which is a commit message.
Reporter | ||
Comment 1•8 years ago
|
||
It seems to me that there are various inconsistent in the diff viewer of MozReview for commit message.
In https://reviewboard.mozilla.org/r/118206/diff/5/ if you compare orig..2, you would see both "commit-message" and a "commit-message-800ba", while orig..1 has only "commit-message". It indicates that "commit-message-800ba" is something introduced from 1..2, however, 1..2 only has change to "commit-message" as well.
In 4..5, you can see three commit-message files in the list, which are "commit-message", "commit-message-800ba", and "commit-message-875d6".
This may be related.
Comment 2•8 years ago
|
||
I filed this earlier as bug 1346321 (and observed comment 1 there as well). Sorry for duplicated work. Marking as a dupe.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Comment 3•8 years ago
|
||
Renaming first file to "commit-message" happens in the front-end only.
1-2 had no change in commit-message and the filediff shouldn't be renamed (see bug 1345740).
Updated•6 years ago
|
Product: MozReview → Conduit
You need to log in
before you can comment on or make changes to this bug.
Description
•