Closed
Bug 1346698
Opened 8 years ago
Closed 8 years ago
Duplicated l10n strings landed in bug 1333602
Categories
(DevTools :: Debugger, enhancement)
DevTools
Debugger
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: flod, Assigned: jlast)
References
Details
Attachments
(1 file)
(deleted),
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
Bug 1333602 introduced a duplicated string sourceSearch.search in debugger.properties, and this is causing one of our localization tools to misbehave. https://hg.mozilla.org/releases/mozilla-aurora/file/default/devtools/client/locales/en-US/debugger.properties#l388 # LOCALIZATION NOTE (sourceSearch.search): The center pane Source Search # prompt for searching for files. sourceSearch.search=Search Sources… # LOCALIZATION NOTE (sourceSearch.search): The center pane Source Search # prompt for searching for files. # Used in the old debugger fronted sourceSearch.search=Search… I assume we should keep the first at this point.
Summary: 1333602 → Duplicated l10n strings landed in bug 1333602
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → jlaster
Attachment #8851047 -
Flags: review?(francesco.lodolo)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8851047 [details] [diff] [review] fix-duplicate-locale.patch Review of attachment 8851047 [details] [diff] [review]: ----------------------------------------------------------------- I'm a bit confused between this patch (which removes the duplicate) and the PR on GitHub that renames one of the two. Both solve the problem, but I would need to understand why the different approach on two different repos.
Attachment #8851047 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7eebc7de24c7 Remove duplicated l10n strings landed in bug 1333602. r=flod
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7eebc7de24c7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Reporter | ||
Comment 5•8 years ago
|
||
I realized we should have probably removed the other one. When the last version of debugger will land on m-c, sourceSearch.search will switch back to "Search…", and a new sourceSearch.search2 ("Search sources…") will land. https://github.com/devtools-html/debugger.html/pull/2445/files This has been messy for a few cycles, so nothing blocking, mostly trying to make sense of the changes.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•