Closed
Bug 1346739
Opened 8 years ago
Closed 8 years ago
Update aboutTelemetry.js to async function & await
Categories
(Toolkit :: Telemetry, defect, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub, Mentored)
References
Details
(Whiteboard: [measurement:client] [lang=js])
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170227084058
Comment 1•8 years ago
|
||
Good call, thanks for filing!
Mentor: alessio.placitelli, gfritzsche
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Summary: Update aboutTelemetry.js to async fucntion & await → Update aboutTelemetry.js to async function & await
Whiteboard: [measurement:client] [lang=js]
Comment hidden (mozreview-request) |
Attachment #8846591 -
Flags: review?(gfritzsche)
Attachment #8846591 -
Flags: review?(alessio.placitelli)
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Assignee: nobody → flyinggrub
Comment 4•8 years ago
|
||
Comment on attachment 8846591 [details]
Bug 1346739 - Update aboutTelemetry.js to async fucntion & await
I'm leaving this one to Alessio.
Attachment #8846591 -
Flags: review?(gfritzsche)
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8846591 -
Flags: review?(gfritzsche)
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8846591 [details]
Bug 1346739 - Update aboutTelemetry.js to async fucntion & await
https://reviewboard.mozilla.org/r/119632/#review121926
This looks good, thanks! Please change the commit message as shown below before we can land this.
Also, please do the following tests locally and let me know if they work:
- Build Firefox with your changes
- Run it using ./mach run
- Open the about:telemetry page
- Make sure that the bits you changed still work (e.g. archivied pings are still loaded and displayed)
If you don't have any archived pings, just close Firefox and open it again.
::: commit-message-f9362:2
(Diff revision 3)
> +Bug 1346739 - Update aboutTelemetry.js to async fucntion & await
> +Replaced all Task occurence by an async function
Please leave a blank line before this line.
Attachment #8846591 -
Flags: review?(alessio.placitelli) → review+
Comment hidden (mozreview-request) |
Attachment #8846591 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 10•8 years ago
|
||
Everything was working normally when running the build and changing to an archived ping.
I also added a blank line as asked :).
Comment 11•8 years ago
|
||
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3cc331de51d8
Update aboutTelemetry.js to async fucntion & await r=Dexter
Comment 12•8 years ago
|
||
(In reply to flyingrub from comment #10)
> Everything was working normally when running the build and changing to an
> archived ping.
> I also added a blank line as asked :).
Nice job! I'm landing this for you ;)
Comment 13•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•