Closed
Bug 1346874
Opened 8 years ago
Closed 8 years ago
Skip slower gray marking checks on Android
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
It's looking to me like the Android debug slowdown is a little excessive, so at least for now, I'd like to disable the additional checks on that platform and configuration only.
Comment 1•8 years ago
|
||
this is valid
Comment 2•8 years ago
|
||
I think that makes sense. There shouldn't be much Android-specific code that interacts with gray marking.
Assignee | ||
Comment 3•8 years ago
|
||
oops, I never posted the patch for review.
Attachment #8846755 -
Flags: review?(continuation)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Updated•8 years ago
|
Attachment #8846755 -
Flags: review?(continuation) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42720d7bd306
Skip gray mark check stack walk on DEBUG Android, r=mccr8
Comment 5•8 years ago
|
||
sfink - Thanks very much for your efforts here. +1 for the strategy of checking less on Android...but are you sure it is working? I was expecting a dramatic savings, but the Android Debug job times look about the same before/after your push on inbound, and some of the timeouts that started with the gray marking seem to be persisting (there have only been a few pushes since yours, so it's early and hard to say, but a few of the timeout failures have happened already). Maybe the ifdef is wrong somehow? Maybe most of the time for gray marking is going somewhere else??
Comment 6•8 years ago
|
||
There's also the "run the GC over and over again!" checks that might be taking lots of time.
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 9•8 years ago
|
||
:sfink, sorry this fix didn't do the trick :( Do you have another fix in the works that will land this week? We are a couple weeks into some top intermittents and I would like to temporarily disable on Friday if we don't have something close to landing by then.
Flags: needinfo?(sphink)
Assignee | ||
Comment 10•8 years ago
|
||
Moar Android test disabling.
Attachment #8848277 -
Flags: review?(continuation)
Updated•8 years ago
|
Attachment #8848277 -
Flags: review?(continuation) → review+
Comment 11•8 years ago
|
||
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47db00299f4
Disable slow gray mark checks on Android, r=mccr8
Assignee | ||
Comment 12•8 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #9)
> :sfink, sorry this fix didn't do the trick :( Do you have another fix in
> the works that will land this week? We are a couple weeks into some top
> intermittents and I would like to temporarily disable on Friday if we don't
> have something close to landing by then.
Yeah, I'm throwing in the towel and disabling bug 1335751 entirely on Android.
Flags: needinfo?(sphink)
Comment 13•8 years ago
|
||
First few Android test results on inbound are looking good now. Thanks Steve.
Comment 14•8 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•