Closed
Bug 1346893
Opened 8 years ago
Closed 5 years ago
Move mobile/android/themes/core/content.css to layout/style/res/
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: emilio)
References
()
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
It seems to me that mobile/android/themes/core/content.css is effectively
an UA style sheet since it has a lot of styles that affect HTML web content.
As such, I tend to think it should live under layout/style/res/ so that
changes to it are reviewed under the same rules as UA style sheet changes
on other platforms. It's rather confusing to have some rules for say
HTML checkbox/radio controls live in layout/style/res/forms.css (there's
even a %ifdef Android section in that file) and then have additional
rules for the same controls under mobile/...
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Make it a regular stylesheet.
This allows it to be cached in shared memory if possible, and will allow me to
stop adding the stylesheet based on a pref for bug 1618202.
|
||
Updated•5 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c1c55d16e1a
Move the Geckoview UA sheet to layout/style. r=snorp
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd054e762cfa
Backed out changeset 8c1c55d16e1a for bc failures on browser_all_files_referenced.js.
|
||
Comment 4•5 years ago
|
||
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8c1c55d16e1ad18934cff6bed55e5329bb7bb81b&selectedJob=290624130
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=290624130&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/fd054e762cfa002027014764b6292012931e30a7
Flags: needinfo?(emilio)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/830880e1c188
Move the Geckoview UA sheet to layout/style. r=snorp
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•