Closed
Bug 1346910
Opened 8 years ago
Closed 8 years ago
mscom::Interceptor is not correctly wrapping output of IServiceProvider::QueryService
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: aes+)
Attachments
(1 file)
It isn't using the iid_is() annotation from the IDL, so even though we actually know the IID of the output interface, the Interceptor sees it (and proxies it) as just an IUnknown. OTOH, a remote client is already expecting it to be the requested interface, so that IUnknown proxy is cast as something more sophisticated, without the right kind of proxy to back it.
|
Assignee | |
Comment 1•8 years ago
|
||
(A more definitive, generic fix is bug 1346957, but for now I'll just do a one-off patch to catch this case)
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847184 [details]
Bug 1346910: Ensure that the interface output by IServiceProvider::QueryService is correctly wrapped by the mscom interceptor;
https://reviewboard.mozilla.org/r/120184/#review122136
Attachment #8847184 -
Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a49e0b563e76
Ensure that the interface output by IServiceProvider::QueryService is correctly wrapped by the mscom interceptor; r=jimm
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•