Closed
Bug 1347013
Opened 8 years ago
Closed 6 years ago
[de-xbl] remove unused binding id="popup-base"
Categories
(Thunderbird :: Mail Window Front End, task)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: aceman, Assigned: mkmelin)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
How can we determine if binding id="popup=base" in mailWidgets.xml is unused? The source shows no references to it: https://dxr.mozilla.org/comm-central/search?q=popup-base&redirect=false There is a binding of the same name in mozilla/toolkit/content/widgets/popup.xml (isn't there a collision?). I have put a dump() into the constructor of the binding and run whole mozmill suite and there are no hits.
![]() |
||
Comment 1•8 years ago
|
||
One call got removed by you ;-) in https://hg.mozilla.org/comm-central/rev/73850fe23239#l1.12 , the other one in https://hg.mozilla.org/comm-central/rev/d031447ec78b#l3.12
Summary: unused binding id="popup=base" in mailWidgets.xml ? → unused binding id="popup-base" in mailWidgets.xml ?
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mkmelin+mozilla
Blocks: tb-war-on-xbl
Severity: trivial → normal
Type: enhancement → task
Summary: unused binding id="popup-base" in mailWidgets.xml ? → [de-xbl] remove unused binding id="popup-base"
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Comment 3•6 years ago
|
||
Comment on attachment 9056505 [details] [diff] [review] bug1347013_remove_popup-base.patch Review of attachment 9056505 [details] [diff] [review]: ----------------------------------------------------------------- Looks good (and good riddance to unused code).
Attachment #9056505 -
Flags: review?(paul) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f6f2323f61c7
remove unused popup-base binding. r=pmorris
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•