:aceman Reporter
	Description • 8 years ago

How can we determine if binding id="popup=base" in mailWidgets.xml is unused?
The source shows no references to it:
https://dxr.mozilla.org/comm-central/search?q=popup-base&redirect=false
There is a binding of the same name in mozilla/toolkit/content/widgets/popup.xml (isn't there a collision?).

I have put a dump() into the constructor of the binding and run whole mozmill suite and there are no hits.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 1 • 8 years ago

One call got removed by you ;-) in https://hg.mozilla.org/comm-central/rev/73850fe23239#l1.12 , the other one in https://hg.mozilla.org/comm-central/rev/d031447ec78b#l3.12

	Paul Morris [:pmorris]
	Comment 3 • 6 years ago

Comment on attachment 9056505 [details] [diff] [review]
bug1347013_remove_popup-base.patch

Review of attachment 9056505 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (and good riddance to unused code).