Closed
Bug 1347037
Opened 8 years ago
Closed 7 years ago
Extract toolbar site identity logic into standalone place
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: walkingice, Assigned: walkingice)
References
Details
Attachments
(2 files)
There is a icon in toolbar to present site identity as
* a global icon, if the site is not security(not https)
* a shield icon, if not-tracking-mode enabled
* etc....
So far the implementation is `ToolbarDisplayLayout.updateSiteIdentity`. Apart from toolbar of Fennec, CustomTabs will use the same site identity in its ActionBar.
This bug aims at creating reusable class which provides same logic to both of Fennec-Toolbar and CustomTabs-Actionbar.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874794 [details]
Bug 1347037 - improve SecurityModeUtil and add test cases
https://reviewboard.mozilla.org/r/146180/#review150728
Attachment #8874794 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874795 [details]
Bug 1347037 - use SecurityModeUtil in ToolbarDisplayLayout
https://reviewboard.mozilla.org/r/146182/#review150730
Attachment #8874795 -
Flags: review?(s.kaspari) → review+
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2ca8f5056de
improve SecurityModeUtil and add test cases r=sebastian
https://hg.mozilla.org/integration/autoland/rev/2f5256c8838f
use SecurityModeUtil in ToolbarDisplayLayout r=sebastian
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2ca8f5056de
https://hg.mozilla.org/mozilla-central/rev/2f5256c8838f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•