Closed
Bug 1347044
Opened 8 years ago
Closed 8 years ago
Shrink two gPSMutex thread-locking scopes in platform.cpp
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
We're getting a deadlock on automation due to calling JS_ParseJSON() in the
profiler with gPSMutex locked.
|
Assignee | |
Comment 1•8 years ago
|
||
The most important of these is the one in profiler_get_profile_jsobject().
Currently the JS_ParseJSON() call frequently leads to deadlock, due to
profiler_log() being called within it.
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8846985 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3390f735714dd71499d19846a6288e3355a32773 shows this fixes the problem. I did 10 runs of the Linux64 debug devtools mochitests and they were all green. Without this fix they were failing ~50% of the time.
|
||
Updated•8 years ago
|
Attachment #8846985 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf9d1b5e5665dccc09118909ac221c32ce42508a
Bug 1347044 - Shrink two gPSMutex thread-locking scopes in platform.cpp. r=mstange.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•