Closed
Bug 1347060
Opened 8 years ago
Closed 6 years ago
Remove marionette test for rotatable devices
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: TYLin, Assigned: manishkk)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
TYLin
:
review+
|
Details | Diff | Splinter Review |
Specifically, test_caret_position_after_changing_orientation_of_device() [1].
[1] http://searchfox.org/mozilla-central/rev/a5c2b278897272497e14a8481513fee34bbc7e2c/layout/base/tests/marionette/test_accessiblecaret_selection_mode.py#502-503
|
Assignee | |
Comment 1•7 years ago
|
||
need to remove only these 2 lines or anything else?
(In reply to Ting-Yu Lin [:TYLin] (UTC+8) (Away, use ni? please) from comment #0)
> Specifically, test_caret_position_after_changing_orientation_of_device() [1].
>
> [1]
> http://searchfox.org/mozilla-central/rev/
> a5c2b278897272497e14a8481513fee34bbc7e2c/layout/base/tests/marionette/
> test_accessiblecaret_selection_mode.py#502-503
Flags: needinfo?(aethanyc)
|
Reporter | |
Comment 2•7 years ago
|
||
Not only these two lines, but the entire functions.
https://dxr.mozilla.org/mozilla-central/rev/0ceabd10aac2272e83850e278c7876f32dbae42e/layout/base/tests/marionette/test_accessiblecaret_selection_mode.py#498-524
Flags: needinfo?(aethanyc)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Reporter | |
Comment 4•6 years ago
|
||
Comment on attachment 9005492 [details] [diff] [review]
Patch_Bug1347060
Review of attachment 9005492 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Thanks!
Attachment #9005492 -
Flags: review?(aethanyc) → review+
|
|
Reporter | |
Updated•6 years ago
|
Whiteboard: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2402bdef40
Remove marionette test for rotatable devices r=TYLin
|
||
Updated•6 years ago
|
Whiteboard: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab32c7bf37a4
Remove marionette test for rotatable devices r=TYLin
|
|
||
Comment 7•6 years ago
|
||
Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•