Closed
Bug 1347092
Opened 7 years ago
Closed 7 years ago
Make CreateTxn*() return already_AddRefed<*> of editor
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cbc3844ace7
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847610 [details] Bug 1347092 part.1 Make EditorBase::CreateTxnForDeleteNode() return already_AddRefed<DeleteNodeTransaction> https://reviewboard.mozilla.org/r/120556/#review122774
Attachment #8847610 -
Flags: review?(m_kato) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847611 [details] Bug 1347092 part.2 Make EditorBase::CreateTxnForDeleteInsertionPoint() return already_AddRefed<EditTransactionBase> https://reviewboard.mozilla.org/r/120558/#review122776
Attachment #8847611 -
Flags: review?(m_kato) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847612 [details] Bug 1347092 part.3 Make EditorBase::CreateTxnForDeleteSelection() return already_AddRefed<EditAggregateTransaction> https://reviewboard.mozilla.org/r/120560/#review122784
Attachment #8847612 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/8a54625f1010 part.1 Make EditorBase::CreateTxnForDeleteNode() return already_AddRefed<DeleteNodeTransaction> r=m_kato https://hg.mozilla.org/integration/autoland/rev/c1a6c7247d54 part.2 Make EditorBase::CreateTxnForDeleteInsertionPoint() return already_AddRefed<EditTransactionBase> r=m_kato https://hg.mozilla.org/integration/autoland/rev/0ebf1fc10396 part.3 Make EditorBase::CreateTxnForDeleteSelection() return already_AddRefed<EditAggregateTransaction> r=m_kato
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8a54625f1010 https://hg.mozilla.org/mozilla-central/rev/c1a6c7247d54 https://hg.mozilla.org/mozilla-central/rev/0ebf1fc10396
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•