Open Bug 1347170 Opened 7 years ago Updated 2 years ago

Permissions pop-up points to “Show site information” icon after moving the tab to new window

Categories

(Firefox :: Site Permissions, defect, P5)

defect

Tracking

()

Tracking Status
firefox52 --- unaffected
firefox53 --- fix-optional
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- fix-optional

People

(Reporter: vtamas, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy] )

Attachments

(1 file)

[Affected versions]:
Firefox 55.0a1 (2017-03-14)
Firefox 54.0a2 (2017-03-14)
Firefox 53.0b1 (20170307064827)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 14.04 64-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Click on “+ Add to Firefox” button to install the following webextension: https://addons.mozilla.org/en-US/firefox/addon/screenshot-capture-annotate/?src=ss. 
5.While permissions pop-up is displayed open the tab context menu and select “Move to New Window” option. 

[Expected Results]:
Permission pop-up is correctly displayed after moving the tab to a new window. 

[Actual Results]:
- Permissions pop-up indicates to “Show site information” icon.
- See attached screencast.


[Additional Notes]: 
This behavior is not encountered with extensions.webextPermissionPrompts set to false because the pop-up is automatically closed after moving to a new window.
Florian, I'm guessing you probably know the answer to this much faster than I could figure it out?
Flags: needinfo?(florian)
I(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #0)

> [Actual Results]:
> - Permissions pop-up indicates to “Show site information” icon.
> - See attached screencast.

Did you forget to attach the screencast file?

(In reply to Andrew Swan [:aswan] from comment #1)
> Florian, I'm guessing you probably know the answer to this much faster than
> I could figure it out?

Are there DOM changes we need to apply in the new window when we get the 'swapping' notification? A second parameter is provided, containing the new browser element.
Flags: needinfo?(florian)
Attached image Animation.gif (deleted) —
(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Did you forget to attach the screencast file?

Yes, sorry for that!
Is it something that happens only with the webextension prompts, or does it happen for camera permission prompts too? (you can use the camera button on https://permission.site/ to see that prompt).

Is it a regression?
Yup, not specific to add-ons. It's also strange that while I can reproduce for camera, the geolocation and notifications popups just mysteriously disappear for me on OSX at least.
Component: Add-ons Manager → Site Identity and Permission Panels
Product: Toolkit → Firefox
Whiteboard: [fxprivacy] [triage]
(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> Is it something that happens only with the webextension prompts, or does it
> happen for camera permission prompts too? (you can use the camera button on
> https://permission.site/ to see that prompt).
> 
> Is it a regression?

This issue also reproduces for camera permission prompts.
It seems to be a regression from Bug 1328304

Last good revision: 771f1590f03efec066b2118cad52f11fd17d43ce
First bad revision: 785314dbec5772bc3b0f0bc18f6ab63fec750193
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=771f1590f03efec066b2118cad52f11fd17d43ce&tochange=785314dbec5772bc3b0f0bc18f6ab63fec750193

(In reply to Johann Hofmann [:johannh] from comment #5)
> Yup, not specific to add-ons. It's also strange that while I can reproduce
> for camera, the geolocation and notifications popups just mysteriously
> disappear for me on OSX at least.

I also can confirm this. Tested on Windows 10 64-bit.
Blocks: 1328304
Keywords: regression
I filed bug 1347503 to handle the swapping of geolocation and notifications. This bug can focus on the (minor) issue of point to the identity icon.
Even though this is technically a regression; this isn't a high priority Firefox 53.
Priority: -- → P3
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
As 54 was released, mark 54 won't fix.
No longer blocks: webext-permissions
Priority: P3 → P5
Component: Site Identity → Site Permissions
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: