Closed
Bug 1347381
Opened 8 years ago
Closed 8 years ago
stylo: Restyle is not triggered properly when changing condition text of media rule
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: emilio)
References
Details
Attachments
(2 files)
See the attached testcase.
The call chain in the testcase is:
ServoMediaRule::SetConditionText ->
MediaList::SetMediaText ->
ServoMediaList::SetText ->
Servo_MediaList_SetText
MediaList::SetMediaText calls MediaList::DoMediaChange to notify the document about the rule change, which is shared between Gecko and Stylo.
I'm not sure what's going wrong here.
The testcase is simplified from test_condition_text_assignment.html.
Assignee | ||
Comment 1•8 years ago
|
||
I have a patch that fixes the issue, I need to see if it's totally correct though.
Assignee | ||
Comment 2•8 years ago
|
||
Ended up being a lot simpler, patch incoming.
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8847733 [details]
Bug 1347381: Tell Servo earlier about stylesheet changes.
https://reviewboard.mozilla.org/r/120660/#review122764
Attachment #8847733 -
Flags: review?(cam) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → emilio+bugs
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2ab0ae532ebb
Tell Servo earlier about stylesheet changes. r=heycam
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a86967a1349
Adjust test expectations to account for new passes. r=emilio
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ab0ae532ebb
https://hg.mozilla.org/mozilla-central/rev/8a86967a1349
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•