Closed
Bug 1347820
Opened 8 years ago
Closed 8 years ago
Label ScrollSelectionIntoViewEvent for nsSelection
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: chenpighead, Assigned: chenpighead)
References
Details
Attachments
(1 file)
Comparing with other labeling works for layout/generic/ folder, this is relatively trivial. Let's move this as a separate bug, so we can keep moving forward.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8847957 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.
https://reviewboard.mozilla.org/r/120892/#review122844
::: layout/generic/nsSelection.cpp:6189
(Diff revision 1)
>
> RefPtr<ScrollSelectionIntoViewEvent> ev =
> - new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> + new ScrollSelectionIntoViewEvent(this, aRegion, aVertical, aHorizontal,
> - aFlags);
> + aFlags);
> - nsresult rv = NS_DispatchToCurrentThread(ev);
> + nsresult rv;
> + nsIDocument* doc = this->GetParentObject();
No need for "this->".
Attachment #8847957 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8847957 [details]
Bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection.
https://reviewboard.mozilla.org/r/120892/#review122844
> No need for "this->".
Yep, I'll fix it.
Thank you for the review. :)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•8 years ago
|
||
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9689473edba
Label ScrollSelectionIntoViewEvent for nsSelection. r=heycam
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•