Closed
Bug 1348155
Opened 8 years ago
Closed 8 years ago
Annotate allocation API
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Due to bug 1348154, the compilation order of different jemalloc versions can break the analysis.
Assignee | ||
Comment 1•8 years ago
|
||
I played whackamole for a little while because there are a bunch of common functions that all of the alloc and free things go through in newer jemalloc, but eventually I decided to go the direct route.
Attachment #8848304 -
Flags: review?(jcoppeard)
Assignee | ||
Comment 2•8 years ago
|
||
This fixes chmanchester's hazard problem, according to https://treeherder.mozilla.org/#/jobs?repo=try&revision=3218e7ac9aa4343e336bb6d89e604f04b198e555&filter-tier=1&filter-tier=2&filter-tier=3
Comment 3•8 years ago
|
||
Comment on attachment 8848304 [details] [diff] [review]
Annotate allocation API
Review of attachment 8848304 [details] [diff] [review]:
-----------------------------------------------------------------
So just ignore everything under malloc and friends? Sounds like a plan.
::: js/src/devtools/rootAnalysis/annotations.js
@@ +14,5 @@
> + // "je_malloc_message" : true,
> + // "je_ialloc": true,
> + // "je_isalloc": true,
> + // "chunk_dalloc" : true,
> + // "chunk_alloc" : true,
I guess we want to remove this chunk.
Attachment #8848304 -
Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/579d55b744c0
Annotate allocation API, r=jonco
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•