Closed Bug 1348155 Opened 8 years ago Closed 8 years ago

Annotate allocation API

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Due to bug 1348154, the compilation order of different jemalloc versions can break the analysis.
Attached patch Annotate allocation API (deleted) — Splinter Review
I played whackamole for a little while because there are a bunch of common functions that all of the alloc and free things go through in newer jemalloc, but eventually I decided to go the direct route.
Attachment #8848304 - Flags: review?(jcoppeard)
Comment on attachment 8848304 [details] [diff] [review] Annotate allocation API Review of attachment 8848304 [details] [diff] [review]: ----------------------------------------------------------------- So just ignore everything under malloc and friends? Sounds like a plan. ::: js/src/devtools/rootAnalysis/annotations.js @@ +14,5 @@ > + // "je_malloc_message" : true, > + // "je_ialloc": true, > + // "je_isalloc": true, > + // "chunk_dalloc" : true, > + // "chunk_alloc" : true, I guess we want to remove this chunk.
Attachment #8848304 - Flags: review?(jcoppeard) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: