Closed
Bug 1348236
Opened 8 years ago
Closed 8 years ago
Label nsAutoScrollTimer for nsSelection
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: chenpighead, Assigned: chenpighead)
References
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8848437 [details]
Bug 1348236 - coding style fixes for nsAutoScrollTimer and its uses in nsSelection.
https://reviewboard.mozilla.org/r/121358/#review123662
Thanks for keeping this in a separate patch.
Attachment #8848437 -
Flags: review?(cam) → review+
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8848438 [details]
Bug 1348236 - label nsAutoScrollTimer for nsSelection.
https://reviewboard.mozilla.org/r/121360/#review123664
::: layout/generic/nsSelection.cpp:268
(Diff revision 2)
> if (!mTimer)
> {
Oh, I guess you could fix this one up in the previous patch if you want.
Attachment #8848438 -
Flags: review?(cam) → review+
Assignee | ||
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8848438 [details]
Bug 1348236 - label nsAutoScrollTimer for nsSelection.
https://reviewboard.mozilla.org/r/121360/#review123674
::: layout/generic/nsSelection.cpp:268
(Diff revision 2)
> if (!mTimer)
> {
Ooops, this is the actual one that I'd like to fix in the first place. I'll fix this one in the previous patch. Thank you for the review. :)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•8 years ago
|
||
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3679b95b3b46
coding style fixes for nsAutoScrollTimer and its uses in nsSelection. r=heycam
https://hg.mozilla.org/integration/autoland/rev/4f1f7620b616
label nsAutoScrollTimer for nsSelection. r=heycam
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3679b95b3b46
https://hg.mozilla.org/mozilla-central/rev/4f1f7620b616
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•