Closed
Bug 1348254
Opened 8 years ago
Closed 8 years ago
Update color palette for grid highlighters in the layout panel
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The default colors proposed in the layout panel are too bright and hard to see on most grid demo sites we have available.
The first color should be the same dark purple as the one proposed when creating the highlighter from the rule view.
Updated•8 years ago
|
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Updated•8 years ago
|
Assignee: zer0 → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
Since we currently cannot display more than one grid, we were thinking about going back to having a single default color (the dark purple we have today on release: #4B0082).
Jen, let us know if you'd still prefer to have different default colors.
Flags: needinfo?(jensimmons)
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8853985 [details]
Bug 1348254 - grid inspector: update grid inspector colors;
https://reviewboard.mozilla.org/r/125992/#review128648
Attachment #8853985 -
Flags: review?(gl) → review+
Comment 4•8 years ago
|
||
I'm torn about this. On the one hand, let's keep to our roadmap and setup the mental model for future users now. On the other hand, maybe it is better to have one color, and figure out the rest later. Mostly I'm frustrated with this process of not designing the overall system, and instead making important products and design decisions in tiny separate conversations, without enough time to consider or see the whole. No good design work is ever done in such a fashion. Projected designed in this way end up scattered and disjoined.
I don't have time (or the authority) to think about the whole system. And so, I do not know what the wise decision is. Any of us could argue our personal opinion. But again, that's not how good design work is done.
"I personally don't like the colors" is a place to start, but not a compelling solution. Engineering should be done from a longer-term design-driven roadmap.
Having separate colors is not just about making it clear which grid is which when multiple grids are turned on. It's about setting up a helpful mental model in the dev-tool user's mind, so they understand what's happening — how grid works, what they've built.
I'm sorry that I don't have a couple days to get into this. I just can't.
Flags: needinfo?(jensimmons)
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
Thanks Jen. You are right and I agree. We did have overall designs before starting to work on the new layout panel though: https://projects.invisionapp.com/share/3X87NEBYH#/screens/179720294
I'm afraid they just didn't go that far into the details. So we need some more designer time on this. Unfortunately, although this might change very soon, we don't have a designer currently available for working on DevTools.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07b054e43bb6
grid inspector: update grid inspector colors;r=gl
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 9•7 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-03-17) on Windows 8.1 , 64 Bit !
This bug's fix is Verified with latest Nightly 55.0a1 !
Build ID 20170520030204
User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
[testday-20170519]
QA Whiteboard: [testday-20170519]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•