Closed
Bug 1348293
Opened 8 years ago
Closed 8 years ago
Grid inspector is slow to appear the first time
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1345434
People
(Reporter: jdescottes, Assigned: zer0)
References
(Blocks 1 open bug)
Details
There has been a slight performance regression in the grid inspector.
The first time we toggle a grid highlighter after opening the devtools, the highlighter will only be displayed after a pause of 1 or 2 seconds.
Regression comes from Bug 1343217 (https://hg.mozilla.org/mozilla-central/rev/4746dc671cc2).
To know the available texture size, we create a canvas with a "webgl" context in order to get the MAX_TEXTURE_SIZE parameter from the webgl context.
This by itself takes ~1 second on my machine.
A potential solution will be to implement the virtual canvas approach (Bug 1345434), or maybe have a direct API some platform to get this information without having to create a canvas.
Assignee | ||
Comment 1•8 years ago
|
||
(In reply to Julian Descottes [:jdescottes] from comment #0)
> A potential solution will be to implement the virtual canvas approach (Bug
> 1345434),
As briefly said before, I think we probably need to call this method in the first implementation of the virtual canvas, so that won't change this bug I'm afraid.
But having the display port API exposed to the web content would definitely do the trick, so I'm changing the dependency to that bug.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 2•8 years ago
|
||
I was just thinking that maybe I could use 4096 as max fixed value, like a minimal common denominator; and the virtual canvas should still works. In that case, we might fix this issue when we land the virtual canvas. I'll add the dependency again.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → zer0
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Julian, could you test if this bug is not fixed for you, now that the virtual canvas has landed?
Flags: needinfo?(jdescottes)
Reporter | ||
Comment 4•8 years ago
|
||
Seems to work fine now! Thanks, closing as duplicate.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(jdescottes)
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•