We are shipping lots of files in chrome://global/skin/icons/ that aren't used anywhere: chrome://global/skin/icons/Close.gif windows chrome://global/skin/icons/Error.png linux,mac chrome://global/skin/icons/Landscape.png linux chrome://global/skin/icons/Minimize.gif windows chrome://global/skin/icons/Portrait.png linux chrome://global/skin/icons/Print-preview.png linux chrome://global/skin/icons/Question.png linux chrome://global/skin/icons/Restore.gif windows chrome://global/skin/icons/Search-close.png linux chrome://global/skin/icons/Search-glass.png linux chrome://global/skin/icons/Warning.png linux chrome://global/skin/icons/checkbox.png mac chrome://global/skin/icons/checkbox@2x.png mac chrome://global/skin/icons/close-inverted.png linux chrome://global/skin/icons/close-inverted@2x.png linux chrome://global/skin/icons/close.png linux chrome://global/skin/icons/close@2x.png linux chrome://global/skin/icons/collapse.png linux chrome://global/skin/icons/error-64.png linux,windows chrome://global/skin/icons/error-large.png mac chrome://global/skin/icons/expand.png linux chrome://global/skin/icons/folder-item.png linux chrome://global/skin/icons/information-32.png linux (bug 1347928 ) chrome://global/skin/icons/information-large.png mac (bug 1347928 ) chrome://global/skin/icons/question-large.png mac chrome://global/skin/icons/warning-32.png mac chrome://global/skin/icons/warning-64.png linux,windows chrome://global/skin/icons/warning-large.pnp linux chrome://global/skin/icons/windowControls.png linux

Comment on attachment 8865963 [details] Bug 1348362 - Cleanup chrome://global/skin/icons - Move some shared files to be Linux-only, as they are only used on Linux. https://reviewboard.mozilla.org/r/137556/#review140698 Thanks :)

Comment on attachment 8865964 [details] Bug 1348362 - Cleanup chrome://global/skin/icons - Move shared files to be Windows-only where they are only used on Windows. https://reviewboard.mozilla.org/r/137558/#review140702

Comment on attachment 8865965 [details] Bug 1348362 - Cleanup chrome://global/skin/icons - Remove unused files. https://reviewboard.mozilla.org/r/137560/#review140704 ::: toolkit/themes/shared/non-mac.jar.inc.mn (Diff revision 1) > skin/classic/global/arrow/panelarrow-vertical-themed.svg (../../windows/global/arrow/panelarrow-vertical-themed.svg) > > * skin/classic/global/dirListing/dirListing.css (../../windows/global/dirListing/dirListing.css) > skin/classic/global/icons/autocomplete-search.svg (../../windows/global/icons/autocomplete-search.svg) > - skin/classic/global/icons/close.png (../../windows/global/icons/close.png) > - skin/classic/global/icons/close@2x.png (../../windows/global/icons/close@2x.png) I think you'll have to move these to windows/global/jar.mn

Comment on attachment 8865965 [details] Bug 1348362 - Cleanup chrome://global/skin/icons - Remove unused files. https://reviewboard.mozilla.org/r/137560/#review142130

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s a52695b6989a -d 426c2e8d1d49: rebasing 395562:a52695b6989a "Bug 1348362 - Cleanup chrome://global/skin/icons - Move some shared files to be Linux-only, as they are only used on Linux. r=dao" merging browser/base/content/test/static/browser_all_files_referenced.js merging toolkit/themes/shared/non-mac.jar.inc.mn rebasing 395563:1987751993e4 "Bug 1348362 - Cleanup chrome://global/skin/icons - Move shared files to be Windows-only where they are only used on Windows. r=dao" merging browser/base/content/test/static/browser_all_files_referenced.js merging toolkit/themes/osx/global/jar.mn merging toolkit/themes/shared/non-mac.jar.inc.mn warning: conflicts while merging browser/base/content/test/static/browser_all_files_referenced.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f985817021e Cleanup chrome://global/skin/icons - Move some shared files to be Linux-only, as they are only used on Linux. r=dao https://hg.mozilla.org/integration/autoland/rev/7da161abdad5 Cleanup chrome://global/skin/icons - Move shared files to be Windows-only where they are only used on Windows. r=dao https://hg.mozilla.org/integration/autoland/rev/30122bff45fc Cleanup chrome://global/skin/icons - Remove unused files. r=dao

Sorry, this had to be backed out for various test failures: https://hg.mozilla.org/integration/autoland/rev/3a52a1397ef66b5307800a4e134e59861443487a https://hg.mozilla.org/integration/autoland/rev/27046998f10a689b5c0b47619e83a5ed6ff46832 https://hg.mozilla.org/integration/autoland/rev/ffa19f64606675c43601565e48db5b4ff1cef4c8 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=30122bff45fc09ee1ec92b4eedc7ed94900167be&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable You can find more information in the logs of the failing tests. Please update your patches to fix the issues and resubmit. Thank you.

I've helped Dan update the code - the error-16.png had been mistakenly moved from one jar.mn to the other. The caps test failure was due to relying on a file that isn't used now, so we've picked another one. We'll trigger a try build before pushing this again.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4462867db73b Cleanup chrome://global/skin/icons - Move some shared files to be Linux-only, as they are only used on Linux. r=dao https://hg.mozilla.org/integration/autoland/rev/d2e2e1b31ea9 Cleanup chrome://global/skin/icons - Move shared files to be Windows-only where they are only used on Windows. r=dao https://hg.mozilla.org/integration/autoland/rev/c1f2a232aa65 Cleanup chrome://global/skin/icons - Remove unused files. r=dao

https://hg.mozilla.org/mozilla-central/rev/4462867db73b https://hg.mozilla.org/mozilla-central/rev/d2e2e1b31ea9 https://hg.mozilla.org/mozilla-central/rev/c1f2a232aa65