Closed Bug 1348463 Opened 8 years ago Closed 8 years ago

nsILoadContext::GetOriginAttributes is too slow

Categories

(Core :: General, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1316683

People

(Reporter: smaug, Unassigned)

Details

http://searchfox.org/mozilla-central/rev/c2a60adfc7b16761cbbfcefa2093fa402ba1aa69/docshell/base/LoadContext.cpp#16 does some crazy JS stuff, when it should just use mOriginAttributes when nsILoadContext is C++ implemented.
Blocks: 1348460
er, not perhaps mOriginAttributes, but whatever native method there is to access OA.
Yoshi, do you think you could take a look at this? Somehow make the method fast in the common case when nsILoadContext is C++ implemented.
Flags: needinfo?(allstars.chh)
I started to write a patch for this in bug 1316683 before I saw this. I think this was originally done to avoid having C++ callers go through JSAPI, so maybe that was the thinking behind the implementation, but the implementation certainly doesn't make sense in retrospect. :-) I think we can make this a dupe?
No longer blocks: 1348460
Now this function won't even exist!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(allstars.chh)
You need to log in before you can comment on or make changes to this bug.