Open
Bug 1348530
Opened 7 years ago
Updated 2 years ago
Rewrite tests in devtools/server/tests/unit to use async/await
Categories
(DevTools :: General, task, P3)
DevTools
General
Tracking
(Not tracked)
NEW
People
(Reporter: brennan.brisad, Unassigned)
References
(Blocks 1 open bug)
Details
(The description below is only valid after Bug 1325989 has been resolved) Several files in devtools/server/tests/unit have the ESLint rules no-shadow and/or max-nested-callbacks disabled. They have been disabled with one of the following comments at the top of the file: /* eslint-disable no-shadow, max-nested-callbacks */ /* eslint-disable no-shadow */ /* eslint-disable max-nested-callbacks */ For every such file, remove its comment to enable the rule again, and rewrite the test to use Task.js. Check that there are no issues reported when running ./mach eslint devtools/server/tests/unit/
Priority: -- → P3
Comment 1•7 years ago
|
||
It seems to me that now we might as well go all the way and convert to async+await.
Updated•7 years ago
|
Blocks: devtools-debtools
Updated•7 years ago
|
Blocks: dt-polish-debt
Updated•7 years ago
|
No longer blocks: devtools-debtools
Updated•6 years ago
|
Summary: Rewrite tests in devtools/server/tests/unit to use Task.js → Rewrite tests in devtools/server/tests/unit to use async/await
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•3 years ago
|
Type: defect → task
status-firefox55:
affected → ---
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•