Closed
Bug 1348900
Opened 8 years ago
Closed 8 years ago
Remove NewTimerCallback as it has been replaced by NewNamedTimerCallback.
Categories
(Core :: Panning and Zooming, enhancement, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: kuoe0.tw, Assigned: kuoe0.tw)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
In Bug 1348738, we implemented `NewNamedTimerCallback()`. And all code using `NewTimerCallback()` will be replaced to use `NewNamedTimerCallback()`. So `NewTimerCallback()` will be deprecated.
Comment 1•8 years ago
|
||
I think you mean bug 1348221.
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8850443 [details]
Bug 1348900 - Remove NewTimerCallback as it has been replaced by NewNamedTimerCallback.
https://reviewboard.mozilla.org/r/122418/#review125422
::: commit-message-e06f0:1
(Diff revision 1)
> +Bug 1348900 - Deprecate NewTimerCallback. r?kats
Deprecate is not the same as delete. Please update the commit message to say "Remove NewTimerCallback as it has been replaced by NewNamedTimerCallback"
Attachment #8850443 -
Flags: review?(bugmail) → review+
Assignee | ||
Updated•8 years ago
|
Summary: Deprecate NewTimerCallback → Remove NewTimerCallback as it has been replaced by NewNamedTimerCallback.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3ada26f07c4a407512a7f2305a3e9e8333606da
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
Land this bug after Bug 1342863 merged to m-c to prevent build failed if Bug 1342863 is backed out.
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3389d01dd0da
Remove NewTimerCallback as it has been replaced by NewNamedTimerCallback. r=kats
Comment 8•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•