Closed
Bug 1348919
Opened 8 years ago
Closed 8 years ago
Grid Cell and Area infobars should not overlap
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gl, Assigned: zer0)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8849656 -
Flags: review?(pbrosset) → review?(zer0)
Comment 2•8 years ago
|
||
Sorry I should have done this sooner to avoid wasting 3 days on this review, but I just looked at it and I'd feel more comfortable if Matteo reviewed it instead of me.
Assignee | ||
Comment 3•8 years ago
|
||
Gabriel, sorry I didn't notice this bug until few hours ago!
I was working anyway to a deep refactoring to `moveInfobar` that you've basically reused. Since the current logic in `moveInfobar` is broken (as we saw during the work week in Paris), you want to probably rewrite your code on top of bug 1349275 (once reviewed) that fixes that, but also changes completely how the infobar is working now. I tried to be exhaustive in the comment why that was needed, and how to fix other highlighters that uses the infobar (e.g. the css-grid).
Therefore I'm canceling the review flag for the moment, until we can updated the css-grid's infobars. Let me know if it's okay to you!
Assignee | ||
Updated•8 years ago
|
Attachment #8849656 -
Flags: review?(zer0)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Reporter | ||
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8867658 [details]
Bug 1348919 - forced grid cell infobar and area infobar position;
https://reviewboard.mozilla.org/r/139248/#review142544
Attachment #8867658 -
Flags: review?(gl) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8849656 -
Attachment is obsolete: true
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/161b368464fb
forced grid cell infobar and area infobar position; r=gl
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•