Closed
Bug 1348934
Opened 8 years ago
Closed 8 years ago
Fix comments in ext-theme.js
Categories
(WebExtensions :: Frontend, defect)
WebExtensions
Frontend
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mattw, Assigned: mattw)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
The comment at http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ext-theme.js#196 is missing the word "have".
|
Assignee | |
Updated•8 years ago
|
Summary: Add missing word in comment → Fix comments in ext-theme.js
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → mwein
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849211 [details]
Bug 1348934 - Fix comments in ext-theme.js DONTBUILD
https://reviewboard.mozilla.org/r/122044/#review124096
r=me with the below two issues fixed.
::: commit-message-05bfa:1
(Diff revision 1)
> +Bug 1348934 - fix comments in ext-theme.js r?jaws DONTBUILD
s/fix/Fix/
::: toolkit/components/extensions/ext-theme.js:180
(Diff revision 1)
> extensions.on("shutdown", (type, extension) => {
> let theme = themeMap.get(extension);
>
> - // We won't have a theme if theme's aren't enabled.
> if (!theme) {
> + // We won't have a theme if theme's are disabled.
no apostrophe since this isn't about possession.
Attachment #8849211 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8849211 [details]
Bug 1348934 - Fix comments in ext-theme.js DONTBUILD
https://reviewboard.mozilla.org/r/122044/#review124096
> no apostrophe since this isn't about possession.
Good catch, thanks
| Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61e836d046af
Fix comments in ext-theme.js r=jaws DONTBUILD
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•