Closed
Bug 1349059
Opened 8 years ago
Closed 8 years ago
Add a telemetry for xml:base with for style attribute
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(2 files)
Replace the XMLBaseAttributeWithStyledElement telemetry with a more restrict telemetry hooked inside GetBaseURIForStyleAttr added in bug 1345343. This should give us a more accurate data.
Hopefully this reports a low number so that we can confidently remove the support of xml:base on style attribute.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
bz, could you review this?
This may make normal CSSOM / style attribute parsing marginally slower... I guess it might be fine.
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(bzbarsky)
|
||
Comment 3•8 years ago
|
||
> This may make normal CSSOM / style attribute parsing marginally slower..
Can you please quantify that on an actual testcase?
Flags: needinfo?(bzbarsky) → needinfo?(xidorn+moz)
|
|
Assignee | |
Comment 4•8 years ago
|
||
So I use these two revisions:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fa0cd980376ffaaf36fe88777548271a8ac3439
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b3b92f760f06016b924d81a745d67dce5bb0b50
and run the attached file with them 10 times. The average time doesn't show any significant difference. Actually in the data, the one with this patch is even slightly faster than the one without.
Assignee: nobody → xidorn+moz
Flags: needinfo?(xidorn+moz)
|
|
||
Comment 5•8 years ago
|
||
Great, thank you for checking that!
|
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849357 [details]
Bug 1349059 - Replace XMLBaseAttributeWithStyledElement with XMLBaseAttributeForStyleAttr for a more accurate measurement.
https://reviewboard.mozilla.org/r/122146/#review126062
r=me
Attachment #8849357 -
Flags: review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Thanks.
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(bzbarsky)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/417488619df2
Replace XMLBaseAttributeWithStyledElement with XMLBaseAttributeForStyleAttr for a more accurate measurement. r=bz
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•