Closed
Bug 1349114
Opened 8 years ago
Closed 8 years ago
label CallPrintCallback for HTMLCanvasElement
Categories
(Core :: Graphics: Canvas2D, enhancement)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: chenpighead, Assigned: chenpighead)
References
Details
Attachments
(1 file)
I was running into this while doing Quantum DOM for layout modules. (more specific in Bug 1342870) It can be seen in nsSimplePageSequenceFrame::PrePrintNextPage [1], we call canvas->DispatchPrintCallback to do the rendering process. Since printing is the only user for canvas->DispatchPrintCallback, I figure that I shall label this one as part of my work.
[1] http://searchfox.org/mozilla-central/rev/ee7cfd05d7d9f83b017dd54c2052a2ec19cbd48b/layout/generic/nsSimplePageSequenceFrame.cpp#665
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
Let's see how it goes on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a6e637e1ddb
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try looks fine except few known issues. It's time to ask for review.
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8849428 -
Flags: review?(bugs)
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849428 [details]
Bug 1349114 - label CallPrintCallback for HTMLCanvasElement.
https://reviewboard.mozilla.org/r/122186/#review124416
Attachment #8849428 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Thank you for the review. :)
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1f3d98c2533
label CallPrintCallback for HTMLCanvasElement. r=smaug
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•