This is the bug Kit and I saw when preparing the "light" run file to run TPS as a smoke check against prod. TPS stdout is attached.

Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. https://reviewboard.mozilla.org/r/122902/#review125504 ::: services/sync/modules/engines/passwords.js:104 (Diff revision 1) > }, > > pullAllChanges() { > - let changeset = new Changeset(); > + let changes = {}; > for (let [id, info] of Object.entries(this._store.getAllIDs())) { > - changeset.set(id, info.timePasswordChanged); > + changes[id] = info.timePasswordChanged / 1000; Glad you took this bug because I didn't realize there was a unit mismatch! ::: services/sync/tests/unit/test_password_engine.js:11 (Diff revision 1) > + "@mozilla.org/login-manager/loginInfo;1", Ci.nsILoginInfo, "init"); > + > +const PropertyBag = Components.Constructor( > + "@mozilla.org/hash-property-bag;1", Ci.nsIWritablePropertyBag); > + > +function serverForEngine(engine) { At some point we should move this function into one of the headers... But probably not this bug.

Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88542bb64b97 Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc

Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. Approval Request Comment [Feature/Bug causing the regression]: Bug 1317223. [User impact if declined]: Password syncing is completely broken for new users. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Not yet. Once this patch lands, it can be verified using the TPS test suite. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: Three-line change to fix a change introduced in bug 1317223; includes xpcshell test. [String changes made/needed]: None.

Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. Fix a broken password syncing. Aurora54+.

backed out for causing problems like https://treeherder.mozilla.org/logviewer.html#?job_id=86165032&repo=mozilla-aurora

Re-landed in https://hg.mozilla.org/releases/mozilla-aurora/rev/426f26d1a43efcbf9bed49a01a52afb4b8907c79, tests should pass now that bug 1345005 has been uplifted, too.

Verified.