Closed
Bug 1349805
Opened 8 years ago
Closed 8 years ago
199,500 instances of "NS_ENSURE_TRUE(standardURL) failed" emitted from caps/nsPrincipal.cpp during linux64 debug testing
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
> 199509 WARNING: NS_ENSURE_TRUE(standardURL) failed: file caps/nsPrincipal.cpp, line 229
This warning [1] shows up in the following test suites:
> 9005 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
> 6807 - test-linux64/debug-mochitest-browser-chrome-11 bc11
> 6603 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
> 6268 - test-linux64/debug-mochitest-jetpack JP
> 6246 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
> 6049 - test-linux64/debug-mochitest-browser-chrome-10 bc10
> 5516 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
> 4776 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
> 4428 - test-linux64/debug-mochitest-browser-chrome-12 bc12
> 4391 - test-linux64/debug-mochitest-devtools-chrome-6 dt6
> 4247 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
> 4064 - test-linux64/debug-mochitest-browser-chrome-6 bc6
> 3956 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
> 3893 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
> 3890 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
> 3765 - test-linux64/debug-mochitest-browser-chrome-4 bc4
> 3666 - test-linux64/debug-mochitest-devtools-chrome-9 dt9
> 3539 - test-linux64/debug-mochitest-browser-chrome-1 bc1
> 3451 - test-linux64/debug-mochitest-e10s-10 10
> 3422 - test-linux64/debug-mochitest-devtools-chrome-10 dt10
> 3379 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
> 3343 - test-linux64/debug-mochitest-browser-chrome-7 bc7
> 3279 - test-linux64/debug-mochitest-devtools-chrome-3 dt3
> 3253 - test-linux64/debug-mochitest-browser-chrome-3 bc3
> 3247 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
> 3216 - test-linux64/debug-mochitest-browser-chrome-2 bc2
> 3185 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
> 3001 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
> 2984 - test-linux64/debug-mochitest-chrome-3 c3
> 2847 - test-linux64/debug-mochitest-devtools-chrome-8 dt8
> 2725 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
> 2662 - test-linux64/debug-mochitest-chrome-1 c1
> 2603 - test-linux64/debug-mochitest-devtools-chrome-1 dt1
> 2565 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
> 2525 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
> 2448 - test-linux64/debug-mochitest-devtools-chrome-7 dt7
> 2401 - test-linux64/debug-mochitest-devtools-chrome-4 dt4
> 2360 - test-linux64/debug-mochitest-devtools-chrome-2 dt2
> 2239 - test-linux64/debug-mochitest-browser-chrome-5 bc5
> 2216 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
> 2211 - test-linux64/debug-mochitest-browser-chrome-9 bc9
> 2096 - test-linux64/debug-mochitest-clipboard cl
> 1950 - test-linux64/debug-mochitest-10 10
> 1899 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
> 1880 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
> 1746 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
> 1722 - test-linux64/debug-mochitest-browser-chrome-8 bc8
> 1662 - test-linux64/debug-mochitest-5 5
> 1648 - test-linux64/debug-mochitest-chrome-2 c2
> 1608 - test-linux64/debug-mochitest-clipboard-e10s cl
> 1488 - test-linux64/debug-mochitest-1 1
> 1441 - test-linux64/debug-mochitest-3 3
> 1395 - test-linux64/debug-mochitest-e10s-1 1
> 1392 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
> 1355 - test-linux64/debug-mochitest-devtools-chrome-5 dt5
> 1312 - test-linux64/debug-mochitest-e10s-3 3
> 1226 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
> 1186 - test-linux64/debug-mochitest-2 2
> 1045 - test-linux64/debug-reftest-1 R1
> 1045 - test-linux64/debug-reftest-no-accel-1 Ru1
> 935 - test-linux64/debug-mochitest-e10s-5 5
> 874 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
> 874 - test-linux64/debug-reftest-e10s-1 R1
> 838 - test-linux64/debug-mochitest-6 6
> 821 - test-linux64/debug-mochitest-8 8
> 690 - test-linux64/debug-mochitest-e10s-8 8
> 631 - test-linux64/debug-mochitest-e10s-6 6
> 578 - test-linux64/debug-mochitest-e10s-2 2
> 564 - test-linux64/debug-mochitest-7 7
> 523 - test-linux64/debug-mochitest-9 9
> 523 - test-linux64/debug-mochitest-a11y a11y
> 503 - test-linux64/debug-mochitest-e10s-9 9
> 442 - test-linux64/debug-mochitest-e10s-7 7
> 343 - test-linux64/debug-mochitest-4 4
> 294 - test-linux64/debug-mochitest-webgl-1 gl1
> 275 - test-linux64/debug-mochitest-webgl-2 gl2
> 273 - test-linux64/debug-mochitest-webgl-3 gl3
> 257 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
> 239 - test-linux64/debug-crashtest C
> 223 - test-linux64/debug-mochitest-e10s-4 4
> 213 - test-linux64/debug-mochitest-media-2 mda2
> 208 - test-linux64/debug-firefox-ui-functional-local en-US
> 199 - test-linux64/debug-reftest-no-accel-5 Ru5
> 199 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
> 199 - test-linux64/debug-reftest-5 R5
> 188 - test-linux64/debug-mochitest-media-1 mda1
> 161 - test-linux64/debug-mochitest-gpu-e10s gpu
> 136 - test-linux64/debug-mochitest-media-3 mda3
> 90 - test-linux64/debug-mochitest-media-e10s-3 mda3
> 80 - test-linux64/debug-firefox-ui-functional-remote en-US
> 79 - test-linux64/debug-reftest-no-accel-3 Ru3
> 79 - test-linux64/debug-reftest-3 R3
> 62 - test-linux64/debug-reftest-no-accel-4 Ru4
> 62 - test-linux64/debug-reftest-4 R4
> 62 - test-linux64/debug-crashtest-e10s C
> 61 - test-linux64/debug-mochitest-media-e10s-1 mda1
> 60 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
> 59 - test-linux64/debug-reftest-7 R7
> 59 - test-linux64/debug-reftest-no-accel-7 Ru7
> 59 - test-linux64/debug-mochitest-media-e10s-2 mda2
> 58 - test-linux64/debug-reftest-no-accel-8 Ru8
> 58 - test-linux64/debug-reftest-8 R8
> 46 - test-linux64/debug-reftest-e10s-8 R8
> 46 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
> 41 - test-linux64/debug-reftest-no-accel-6 Ru6
> 41 - test-linux64/debug-reftest-6 R6
> 35 - test-linux64/debug-reftest-e10s-3 R3
> 35 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
> 33 - test-linux64/debug-reftest-2 R2
> 33 - test-linux64/debug-reftest-no-accel-2 Ru2
> 33 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
> 33 - test-linux64/debug-reftest-e10s-4 R4
> 30 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
> 29 - test-linux64/debug-reftest-e10s-5 R5
> 29 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
> 26 - test-linux64/debug-reftest-e10s-7 R7
> 26 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
> 20 - test-linux64/debug-reftest-e10s-2 R2
> 20 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
> 20 - test-linux64/debug-reftest-e10s-6 R6
> 20 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
> 15 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
It shows up in 10676 tests. A few of the most prevalent:
> 8123 - Shutdown
> 5243 - [e10s] Shutdown
> 2214 - jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration
> 546 - [e10s] toolkit/mozapps/extensions/test/browser/browser_discovery.js
> 529 - [e10s] browser/components/sessionstore/test/browser_354894_perwindowpb.js
> 498 - [e10s] toolkit/mozapps/extensions/test/browser/browser_bug562797.js
> 475 - [e10s] browser/components/sessionstore/test/browser_615394-SSWindowState_events.js
> 431 - browser/components/sessionstore/test/browser_354894_perwindowpb.js
> 409 - [e10s] dom/tests/browser/browser_focus_steal_from_chrome.js
> 334 - [e10s] browser/components/sessionstore/test/browser_newtab_userTypedValue.js
[1] https://hg.mozilla.org/mozilla-central/annotate/00c595de1627/caps/nsPrincipal.cpp#l229
|
Assignee | |
Comment 1•8 years ago
|
||
It appears bug 1322514 added an NS_ENSURE_TRUE in an expected code path.
Blocks: 1322514
|
|
Assignee | |
Comment 2•8 years ago
|
||
MozReview-Commit-ID: IgT8ZQ6ByKG
Attachment #8850261 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Attachment #8850261 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebcd681132b2c2aeea106a49f037da7428bb19c5
Bug 1349805 - Convert NS_ENSURE_TRUE in ContentPrincipal::GetOriginInternal to an if statement. r=baku
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•