There are a couple of React-related warnings/errors showing up in the console browser. We should fix these, as mentioned by Patrick: When opening the panel for the first time: "Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `GridList`. See https://fb.me/react-warning-keys for more information. in GridItem (created by GridList) in GridList (created by Grid) in div (created by Grid) in div (created by Grid) in Grid (created by bound createElement) in bound createElement (created by Accordion) in div (created by Accordion) in div (created by Accordion) in div (created by Accordion) in Accordion (created by App) in div (created by App) in App (created by Connect(App)) in Connect(App) in Provider in div (created by Tabs) in div (created by Tabs) in div (created by Tabs) in Tabs (created by Tabbar) in div (created by Tabbar) in Tabbar" And this one too: "Warning: Unknown prop `object` on <span> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop in span (created by ElementNode) in span (created by ElementNode) in ElementNode (created by Rep) in Rep (created by GridItem) in label (created by GridItem) in li (created by GridItem) in GridItem (created by GridList) in ul (created by GridList) in div (created by GridList) in GridList (created by Grid) in div (created by Grid) in div (created by Grid) in Grid (created by bound createElement) in bound createElement (created by Accordion) in div (created by Accordion) in div (created by Accordion) in div (created by Accordion) in Accordion (created by App) in div (created by App) in App (created by Connect(App)) in Connect(App) in Provider in div (created by Tabs) in div (created by Tabs) in div (created by Tabs) in Tabs (created by Tabbar) in div (created by Tabbar) in Tabbar" I also see errors when I click on a checkbox to highlight a grid in the layout panel: Warning: setState(...): Cannot update during an existing state transition (such as within `render` or another component's constructor). Render methods should be a pure function of props and state; constructor side-effects are an anti-pattern, but can be moved to `componentWillMount`. Looking at the stack trace, it seems to be coming from this location: updateBoxModel/lastRequest< resource://devtools/client/inspector/boxmodel/box-model.js:172:7 Finally, I see a lot of errors when I start hovering over cells in the outline. The stack trace tells me these come from: onHighlighterChange resource://devtools/client/inspector/grids/grid-inspector.js:301:5

This doesn't fix the setState errors in grid outline. That will be a separate bug.

Comment on attachment 8855429 [details] Bug 1350046 - Fix react-related errors in the layout panel. https://reviewboard.mozilla.org/r/127280/#review130364 Looks good, thanks!

Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e89725c397f4 Fix react-related errors in the layout panel. r=jdescottes

(In reply to Gabriel [:gl] (ΦωΦ) from comment #2) > This doesn't fix the setState errors in grid outline. That will be a > separate bug. Did you file a bug for this? I see a lot of these errors still when hovering over the outline.

(In reply to Patrick Brosset <:pbro> from comment #6) > (In reply to Gabriel [:gl] (ΦωΦ) from comment #2) > > This doesn't fix the setState errors in grid outline. That will be a > > separate bug. > Did you file a bug for this? I see a lot of these errors still when hovering > over the outline. No, bug has been filed for this yet.