Closed
Bug 1350388
Opened 8 years ago
Closed 8 years ago
Drag&drop some HTTPS links in the download icon displays wrongly download as failed
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | + | verified |
firefox55 | + | verified |
People
(Reporter: epinal99-bugzilla2, Assigned: dragana)
References
Details
(Keywords: regression, Whiteboard: [necko-active])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
valentin
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR:
1) Open https://bugzilla.mozilla.org/
2) Wait for ~10 sec (it's empirical but I only found that to reproduce the issue consistently)
3) Drag&drop the link "Bugzilla@Mozilla" (upper left corner) in the download icon in the toolbar
Result: the download panel displays the yellow mark for "download failed" even if the file has been really downloaded (visible on the disk).
Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5ae59bdcd2d4f9617d6663ab823b4a384fdd6204&tochange=08df0e07f0ba02a27e532b25a0d3415166a6bba1
Dragana Damjanovic — Bug 1343600 - add TLS handshake Start/Stop events. r=:valentin
Blocks: 1343600
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → affected
status-firefox55:
--- → affected
tracking-firefox54:
--- → ?
tracking-firefox55:
--- → ?
Flags: needinfo?(dd.mozilla)
Keywords: regression
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(dd.mozilla)
Whiteboard: [necko-active]
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8852060 -
Flags: review?(valentin.gosu)
Updated•8 years ago
|
Attachment #8852060 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f129d307ce4b
NS_NET_STATUS_TLS_HANDSHAKE_STARTING/ENDED is not an error for nsWebBrowserPersist. r=valentin
Keywords: checkin-needed
Comment 3•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8852060 [details] [diff] [review]
bug_1350388_v1.patch
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1343600
[User impact if declined]: Downloads can be mark as failed, because nsWebBrowserPersist interpret new transport events NS_NET_STATUS_TLS_HANDSHAKE_STARTING/ENDED as an error.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: there are step to reproduce in comment #0
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:none
[Why is the change risky/not risky?]: just add 2 additional transport status events to the list.
[String changes made/needed]:none
Attachment #8852060 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox-esr52:
--- → unaffected
Comment 6•8 years ago
|
||
Comment on attachment 8852060 [details] [diff] [review]
bug_1350388_v1.patch
regression fix for aurora54
Attachment #8852060 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder uplift |
Comment 8•8 years ago
|
||
I have successfully reproduced this bug on firefox nightly according to(2017-03-24)
Fixing bug is verified on Latest Developer Edition-- Build ID : (20170402004002),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:54.0) Gecko/20100101 Firefox/54.0
Tested OS -- Windows10 32bit
[bugday-20170329]
Comment 9•8 years ago
|
||
The issue is no longer reproducible on Firefox 55.0a1 (2017-04-03)
OS:windows 7(32 bit)
[bugday-20170405]
Comment 10•8 years ago
|
||
[bugday-20170412]
The issue is no longer reproducible on Firefox Nightly 55.0a1.
Tests were performed under Windows 10x64.
Comment 11•7 years ago
|
||
[bugday-20170419]
Status: FIXED & VERIFIED.
Browser: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
The issue is no longer reproducible on Firefox Aurora
Tests were performed under Ubuntu 15.10 x64.
Updated•7 years ago
|
Flags: qe-verify+
Comment 12•7 years ago
|
||
I reproduced this issue with Fx 55.0a1 (24-03-2017) on Windows 7 x64.
I can confirm this issue is fixed I verified using Fx 55.0a1 (20170424030211) and Fx 54.0b1 on Windows 7 x64.
Cheers!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Comment 13•7 years ago
|
||
The issue is no longer reproducible on Firefox 52.0.2 (2017-04-03)
OS: macOS Sierra 10.12.3
[bugday-20170405]
You need to log in
before you can comment on or make changes to this bug.
Description
•