Closed
Bug 1350435
Opened 8 years ago
Closed 8 years ago
getSnapshotIdFromPath() shouldn't assume parent and child process have same TmpD
Categories
(DevTools :: Memory, enhancement)
DevTools
Memory
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
See bug 1349389 for details.
But anyways, what happens is the parent process creates a file in the temp directory, sends the file name to the child process which does this:
exports.getSnapshotIdFromPath = function (path) {
return path.slice(OS.Constants.Path.tmpDir.length + 1,
path.length - ".fxsnapshot".length);
};
With the new fancy sandboxing work that is going on, the temp dir in the parent and child are not the same. The child process temp dir has some extra "Temp-{UUID}" stuff added on the end. Therefore, getSnapshotIdFromPath will return an empty string if OS.Constants.Path.tmpDir returns the correct value.
This only happens to incidentally work right now due to a bug in OS.Constants.Path snapshotting the value of tmpDir early in startup, when we eagerly load osfile.jsm from telemetry startup. (I'm going to file a separate bug on that.)
I think the right fix is to compute the snapshot ID in the parent, and send it in the message instead of the path.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → continuation
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
I need to remember to get a DOM peer review for the .webidl change once fitzgen reviews this (I added a chrome-only method that is just a variation of another method, so I can't imagine it will need more than a rubber stamp DOM review).
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8851347 [details]
Bug 1350435 - Compute snapshot ID in the parent process.
https://reviewboard.mozilla.org/r/123662/#review126370
Looks great! Thanks :mccr8 :)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8851347 [details]
Bug 1350435 - Compute snapshot ID in the parent process.
https://reviewboard.mozilla.org/r/123662/#review126372
Attachment #8851347 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8851347 -
Flags: review?(bugs)
Assignee | ||
Comment 5•8 years ago
|
||
Olli, could you look at the .webidl change? Thanks.
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8851347 [details]
Bug 1350435 - Compute snapshot ID in the parent process.
https://reviewboard.mozilla.org/r/123662/#review126380
r+ for the .webidl
Attachment #8851347 -
Flags: review?(bugs) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/951e3cdf5b32
Compute snapshot ID in the parent process. r=fitzgen,smaug
Comment 8•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•