Closed
Bug 1350499
Opened 8 years ago
Closed 8 years ago
Different width/height shown in editbox of boxmodel-content
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 verified)
VERIFIED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | verified |
People
(Reporter: magicp.jp, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Different-width-height-shown-in-editbox-of-boxmodel-content.png
Steps to Reproduce:
1. Start latest Nightly (e.g. Build ID:20170324030205)
2. Go to about:home
3. Open Inspector > Computed
4. Select #aboutMozilla in markup
5. Click width/height on boxmodel-content
Actual Result:
Different width/height is shown. (It seems #aboutMozilla::before size?)
Please refer to attached image.
Expected Result:
Is this intentionally? If not, own width/height is shown as default when editing.
Has STR: --- → yes
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
|
||
Updated•8 years ago
|
|
|
||
Updated•8 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•8 years ago
|
||
We actually have the same issue with margin/border/padding etc...
If a pseudo-element defines a value for any of those properties, and the element itself doesn't, the editing session will pick up the value from the pseudo element.
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8852475 [details]
Bug 1350499 - exclude styles for pseudo-els when building boxmodel widget;
https://reviewboard.mozilla.org/r/124680/#review127246
::: devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_pseudo.js:10
(Diff revision 1)
> +"use strict";
> +
> +// Test that pseudo elements have no side effect on the box model widget for their
> +// container. See bug 1350499.
> +
> +const TEST_URI = "<style>" +
We should just use multiline strings here
Attachment #8852475 -
Flags: review?(gl) → review+
| Comment hidden (mozreview-request) |
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f74f77a9814
exclude styles for pseudo-els when building boxmodel widget;r=gl
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have verified this bug was fixed in latest Nightly build (20170410030221). Thanks!
Status: RESOLVED → VERIFIED
|
||
Comment 8•8 years ago
|
||
[bugday-20170412]
The bug is no longer to be reproducible in Latest Nightly 55.0a1.
OS:Windows 10
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•