Closed
Bug 1350503
Opened 8 years ago
Closed 8 years ago
sharedLibraries return value is broken: "Error: Server did not specify an actor, dropping packet"
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | unaffected |
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: regression)
Attachments
(1 file)
I broke this in bug 1329111 when I made Profiler.sharedLibraries() return a plain array instead of an object with a sharedLibraries property that contains the array.
|
||
Updated•8 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
Component: Developer Tools → Developer Tools: Performance Tools (Profiler/Timeline)
|
||
Comment 1•8 years ago
|
||
Hey Greg, has this been taken care of in GitHub land maybe? Thxx.
Flags: needinfo?(gtatum)
|
Assignee | |
Comment 2•8 years ago
|
||
It hasn't, I should just go ahead and fix it.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Flags: needinfo?(gtatum)
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860147 [details]
Bug 1350503 - Wrap the performance actor's sharedLibraries value inside an object so that it can be transferred through the debugger protocol.
https://reviewboard.mozilla.org/r/132180/#review135360
LGTM.
Attachment #8860147 -
Flags: review?(gtatum) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/28b8c2b9e9fa
Wrap the performance actor's sharedLibraries value inside an object so that it can be transferred through the debugger protocol. r=gregtatum
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•8 years ago
|
status-firefox-esr52:
--- → unaffected
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•