Closed Bug 1350740 Opened 8 years ago Closed 6 years ago

[Learn more] link of console messages should be unselectable

Categories

(DevTools :: Console, defect, P5)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: yfdyh000, Assigned: pradeepgangwar, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first verify])

Attachments

(1 file)

Bug 1350740- Make [Learn More] Link of console message unselectable; r=nchevobbe
(deleted), text/x-phabricator-request
Details
Steps to reproduce: Execute like "a" in web console (got an error, but the case no line number), or find any errors in web console or browser console. Expected results: [Learn more] link not be inserted when copying messages. .message .learn-more-link { -moz-user-select: none; } It can still be focus by keybrond, as -moz-user-focus keep status. Negative effect: It reduces the spacing of message fields, from "message[Learn more] file:line:column" to "message file:line:column". Maybe it should be increased a space, or a " | ".
Hi YF ! I'm not sure I understand the issue here. Could you write a detailed STR and what it does that it shouldn't ? From Comment 0 I can't tell if there's a text selection issue or a focus/keyboard navigation one. Thanks !
Flags: needinfo?(yfdyh000)
STR: Press F12 to open Developer Tools, then go to Console. Execute any command (like an "a") to got an error message: "ReferenceError: a is not defined". Try copy the message(s), got the "ReferenceError: a is not defined [Learn more]" into clipboard. Expected result: "[Learn more]" link not be inserted when copying messages. Expected changes: .message .learn-more-link { -moz-user-select: none; }
Flags: needinfo?(yfdyh000)
Thanks for answering, I got it now
Priority: -- → P3
Product: Firefox → DevTools
Mentor: nchevobbe
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: good-first-bug
Priority: P3 → P5
Hi Nicolas. I would like to work on this bug. Can you assign me this?
Flags: needinfo?(nchevobbe)
Hello Pradeep, thanks for helping us! I assigned the bug to you, don't hesitate to ask any question :)
Assignee: nobody → pradeepgangwar39
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)
Depends on: 1486870

I have a problem with mercurial. Please guide me.
For example I do git pull upstream master --rebase to pull changes from upstream master and add my commits on top of it when i need to update my branch with latest changes.
But how do i do it in mercurial. I did hg pull default --rebase from my Bug-1350740 branch and i am not able to see my commit on top of new changes like we have in git.

Let me know the correct way to handle this.

Flags: needinfo?(nchevobbe)

What I do is usually hg rebase -d central -b {rev} where {rev} is your commit id.

Flags: needinfo?(nchevobbe)

Hello Pradeep,

Is this still blocking you?

Flags: needinfo?(pradeepgangwar39)

I am able to see my commit on top of all commits but its in default branch. Whereas I created that patch from branch named "Bug-1350740". I am unable to locate that branch now. Will it be okay if I do the changes on top of it and push to phabricator? I mean will it reflect in same review request?

Flags: needinfo?(pradeepgangwar39) → needinfo?(nchevobbe)

Since it's a small patch, it's fine if you don't have the branch anymore, as long as the commit was rebased.

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a500b4dd9ee5 Make [Learn More] Link of console message unselectable; r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/a500b4dd9ee5

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: