Closed
Bug 1350988
Opened 8 years ago
Closed 8 years ago
Baldr: fix async interrupt issues
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(3 files)
(deleted),
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The patch here fixes some intermittent failures we were seeing in tests/asm.js/testBug1117255.js.
Assignee | ||
Comment 1•8 years ago
|
||
This patch gives a separate CodeRange::Type for async interrupt stubs so that the profiling frame iterator can simply skip it since the fp register can hold anything.
Attachment #8851678 -
Flags: review?(bbouvier)
Updated•8 years ago
|
Attachment #8851680 -
Flags: review?(bbouvier) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8851678 [details] [diff] [review] async-interrupt-pc Review of attachment 8851678 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8851678 -
Flags: review?(bbouvier) → review+
Comment 4•8 years ago
|
||
Just a drive-by patch, that was nice to have for helping debugging.
Attachment #8851689 -
Flags: review?(luke)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8851689 [details] [diff] [review] fprintf.patch Review of attachment 8851689 [details] [diff] [review]: ----------------------------------------------------------------- Oops, I saw this in your pastebin but thought it was just a temporary debugging printf. It's a good change, though; I always have to do this myself.
Attachment #8851689 -
Flags: review?(luke) → review+
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bcb02e41e118 Baldr: don't attempt to unwind when in the interrupt stub (r=bbouvier) https://hg.mozilla.org/integration/mozilla-inbound/rev/bec48942d615 Baldr: don't clobber scratch register in interrupt stub (r=bbouvier) https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc3829f182d Baldr: send ARM simulator dissassembly output to stderr (r=luke)
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/67bfeed62db8 Baldr: disable new test when single-stepping not enabled (r=red)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bcb02e41e118 https://hg.mozilla.org/mozilla-central/rev/bec48942d615 https://hg.mozilla.org/mozilla-central/rev/6dc3829f182d https://hg.mozilla.org/mozilla-central/rev/67bfeed62db8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•