Nicholas, please send an Intent to Ship e-mail to release-drivers about this

(In reply to :Felipe Gomes (needinfo me!) from comment #3) > Nicholas, please send an Intent to Ship e-mail to release-drivers about this Done.

Wei can you sign this system add-on?

Signed file attached. Please test and verify. Thanks!

NI Rares and Andrei for QA.

Nicholas, Cory, a few questions, as it's not very clear to me what manual QA should do to help test this: 1. could you please elaborate on what steps should we follow to confirm that the system add-on disables predictive prefetch? would it be enough to confirm that the associated preference is false on 52.* and 52.*esr? (i.e. network.predictor.enable-prefetch;false) 2. is this system add-on available on the release-sysaddon update channel? according to the update.xml file associated to 52.0.1-build2-en-US [1], it looks like it isn't on the update channel -- should we test it by manually installing the signed xpi [2] instead? 3. per your email on r-d, this system add-on is only targeting 52.* and 52.*esr, what is the expected status of the predictive prefetch feature on lower versions? (e.g. 51.*, 50.* etc.) [1] https://aus5.mozilla.org/update/3/SystemAddons/52.0.1/20170316213829/default/en-US/release-sysaddon/default/default/default/update.xml [2] per Comment 6

1) Ensuring the pref is set to false is fine. That's already a well-tested state, so as long as the pref is false, we can be confident the feature is disabled. 2) It's not yet available through the channel, you'll have to manually install 3) The feature is already preffed off on releases < 52

(In reply to Nicholas Hurley [:nwgh][:hurley] (also hurley@todesschaf.org) from comment #10) > 2) It's not yet available through the channel, you'll have to manually install Hello Nicholas, I am trying to install the sysaddon from comment6 signed by :wezhou but I'm unable to do so. I keep getting the message that "This add-on could not be installed because it appears to be corrupt" and the following error in console: > XML Parsing Error: syntax error > Location: file:///Users/bogdanmaris/Desktop/signed.attachment.8851787/install.rdf > Line Number 6, Column 1: install.rdf:6:1 I tried to install it the old fashion way by drag drop, from about:addons/Install Add-on from File and from about:debugging#addons as well. Maybe I'm missing something here but, is there another way to install this?

Seems like it's unhappy with the "#filter substitution" line, which looks like a mistake.

Ugh. OK, that's gone. Here's a new version, yet to be signed.

Signed file attached. Please test and verify. Thanks!

Re-upping the QA ni?

Bogdan from Release QA is already working on this -- removing the ni? from Rares (Engineering QA), as his team's assistance is not required at this point. (leaving the ni? on myself until this request is completed)

We just finished testing the add-on from comment 14 and everything worked as expected. Covered OSs: - Windows 10 64bit, macOS 10.12.2 and Ubuntu 16.04 64bit Builds used: - 52 builds (Fx 52beta9, 52.0rc, 52.0.1rc, 52.0.2rc, 52.0esr, 52.0.1esr and 52.0.2esr) Locales used: - three most used locales (en-US, ru and de) Testing results: - `network.predictor.enable-prefetch` changed the value to `false` - Disable Prefetch (1.0, true), disable-prefetch@mozilla.org was displayed in about:support and in about:addons#extensions - Ever after restart or forced crash the pref retained `false` value and Disable Prefetch was still displayed in about:addons and about:addons#extensions.

For more information about the testing done please see the following etherpad: https://public.etherpad-mozilla.org/p/1351082

This should be fixed https://github.com/mozilla/one-off-system-add-ons/pull/29#pullrequestreview-30311903

Fixes one more install.rdf issue

Signed file attached. Please test and verify. Thanks.

Do we have to ship this afresh for every 52.x.xesr release?

It might be better to include the pref flip in the esr52 repo, so that future releases don't need to get the sysaddon out-of-band.

This has been pushed to 52 release. (In reply to Julien Cristau [:jcristau] from comment #23) > It might be better to include the pref flip in the esr52 repo, so that > future releases don't need to get the sysaddon out-of-band. I'm not 100% sure on the mechanics for system add-ons and ESR. :bhearsum, will we need a separate rule for ESR?

(In reply to Cory Price [:ckprice] from comment #24) > This has been pushed to 52 release. > > (In reply to Julien Cristau [:jcristau] from comment #23) > > It might be better to include the pref flip in the esr52 repo, so that > > future releases don't need to get the sysaddon out-of-band. > > I'm not 100% sure on the mechanics for system add-ons and ESR. :bhearsum, > will we need a separate rule for ESR? Yep. The current rules specifies a channel, so you'll need a separate rule with "esr" as the channel to do this. And maybe a separate Release, if this is the *only* SystemAddon we want to ship to those users.

Mass wontfix for bugs affecting firefox 52.

Should this have been closed blindly on the firefox52 cleanup even if it is referencing the Extended Support Release (ESR) one?

This was actually shipped to 52 release channel.