Closed
Bug 1351271
Opened 8 years ago
Closed 7 years ago
Provide tests for commit message FileDiff contents
Categories
(MozReview Graveyard :: Review Board: DiffViewer, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: zalun, Assigned: zalun)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
Details |
Contents of the commit message FileDiff was tested by dumping the ReviewRequest. After commit message has been removed from `Download Diff` API this is no longer sufficient.
There is a need to create a new mach command and use it in the integration test.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → pzalewa
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8851977 -
Flags: review?(mars)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8851977 [details]
mozreview: test commit message FileDiff contents (bug 1351271)
https://reviewboard.mozilla.org/r/124234/#review131430
::: pylib/mozreview/mozreview/extension.py:94
(Diff revision 1)
> commit_data_resource,
> )
> from mozreview.resources.commit_rewrite import (
> commit_rewrite_resource,
> )
> +from mozreview.resources.filediff import (
I think this should go after `ensure_drafts` to keep alphabetized order.
|
||
Updated•8 years ago
|
Attachment #8851977 -
Flags: review?(mars)
|
||
Updated•7 years ago
|
Attachment #8851977 -
Flags: review?(smacleod)
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•